fix(admin): sync identity sequences after restore - #3844
Open
r266-tech wants to merge 1 commit into
Open
Conversation
Strix Security ReviewNo security issues found. Updated for Reviewed by Strix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3841.
Admin restore copies explicit IDs back into the history tables but previously left their identity sequences at the pre-restore position. The next consolidation write could then collide with restored rows and fail permanently.
This change discovers non-cyclic PostgreSQL identity sequences owned by restored columns, then synchronizes them inside the existing restore transaction. It uses catalog-constrained identity dependencies, quoted identifiers, transactional
ALTER SEQUENCE ... RESTART, and an in-transactionnextvalto preserve exhausted sequence bounds without non-transactionalsetval. Cyclic and manually-owned non-generating sequences are deliberately left untouched because table extrema cannot reconstruct their cursor safely.Regression coverage includes both affected history tables with restored ID 337, transaction rollback, empty tables, ascending and descending exhaustion, explicit values outside sequence bounds, cyclic exclusion, quoted identifiers, and manually-owned sequence exclusion.
Verification:
pytest -q hindsight-api-slim/tests/test_admin_backup_restore.py(21 passed)ruff format --check hindsight-api-slim/hindsight_api/admin/cli.py hindsight-api-slim/tests/test_admin_backup_restore.pyruff check hindsight-api-slim/hindsight_api/admin/cli.py hindsight-api-slim/tests/test_admin_backup_restore.pygit diff --check