Repository navigation
feat(sync): keep project lists device-local - #1568
Merged
Merged
Conversation
Project lists describe the workspace on a particular device and should not be recreated by portable configuration sync. Remove their category and adapters while retaining scoped capability mappings. Ignore retired project records in existing vault revisions and local recovery state so upgrades preserve local projects and supported configuration history.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This publishes the one local-only deliverable that was sitting on the local
mainbranch and never reached remotemain: project lists describe theworkspace of a particular device, so portable configuration sync must not
recreate them on another device. Until now
projectswas still a publicConfigSyncCategory, so a synced or restored vault could register unwantedworkspaces on the receiving machine.
The rest of that local branch (
chore(sync)integration commits and the mergecommit) contains only content that remote
mainalready has in a newer form, sothis branch publishes the feature commit alone, rebased onto current
main.Change
projectsfromCONFIG_SYNC_CATEGORIES, the category UI, the adapterregistry, capture, and application; normalize saved and draft category
selections to the supported set.
projectsentities in existing vault revisions and localrecovery state, after the revision has been validated and authenticated in
full, so local projects and supported configuration history survive an
upgrade.
mappings working through their logical identities and explicit local folder
mappings. Local project records and remote revision history stay intact, and
no project deletions are published to retire the category.
docs/adr/device-local-project-lists-in-config-sync.md(plus itszh-CN mirror and index entry), and the updated
03-runtime/22-config-sync.md/06-delivery/04-e2e-test-plan.mdin bothlocales.
Consumers of
ConfigSyncCategorymust stop requestingprojects. Existingencrypted vaults keep validating; older clients may still publish project
entities, and new clients ignore them. Process ownership, encryption, and
approval boundaries are unchanged, and no data is deleted.
Validation
Base
origin/main9d3273fd9; candidate6c5bdae19.cargo test -p host-core --locked→ 823 passed, 0 failed (includeslegacy_project_revision_sync_and_restore_preserve_local_projectsand theconfig-sync S3 suite).
cargo fmt --check -p host-coreclean;cargo clippy -p host-core --all-targetsreports only the two pre-existingtranscripts.rswarningsthat this change does not touch.
node --test test/*.test.mjs→ 3788 passed, 0 failed, includingthe new
config-sync-form/config-sync-preferences/config-sync-user-pathcases.
tsc -p tsconfig.json --noEmitclean. (In a worktree that reuses the hostbuild artifacts, the linked
packages/shared/distis stale; resolving@pi-desktop/sharedto this branch's source reproduces the CI arrangement andthe check passes. CI builds the packages before typechecking.)
packages/sharedvitest → 1236 passed;packages/i18nvitest → 30 passed.biome lintclean;check-locales(85 pairs) andcheck-docs(569 pages)pass.