cluster: initialize primary_id to NULL in parse_cluster_nodes#333
Open
benh57 wants to merge 1 commit into
Open
cluster: initialize primary_id to NULL in parse_cluster_nodes#333benh57 wants to merge 1 commit into
benh57 wants to merge 1 commit into
Conversation
benh57
force-pushed
the
fix-uninitialized-primary-id
branch
from
e5224ee to
3ab444e
Compare
primary_id is declared uninitialized and only written by parse_cluster_nodes_line() when replicas are parsed (a non-NULL parsed_primary_id is passed, i.e. add_replicas). It is later read by retain_replica_node() on replica lines. A replica line is only produced when add_replicas is set, so in practice the value is written before it is read, but that correlation is not visible to the compiler, which warns about a possibly-uninitialized read (-Wmaybe-uninitialized / MSVC /W4, fatal under -Werror). Initialize to NULL to silence the warning and guard against future refactors. Signed-off-by: Ben Hines <bhines@gmail.com>
benh57
force-pushed
the
fix-uninitialized-primary-id
branch
from
3ab444e to
94c8bee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We noticed this because we forked libvalkey locally and built in our own env
primary_id is declared uninitialized and only written by parse_cluster_nodes_line() when replicas are parsed (a non-NULL parsed_primary_id is passed, i.e. add_replicas).
It is later read by retain_replica_node() on replica lines. A replica line is only produced when add_replicas is set, so in practice the value is written before it is read, but that correlation is not visible to the compiler, which warns about a possibly-uninitialized read (-Wmaybe-uninitialized / MSVC /W4, fatal under -Werror).
Initialize to NULL to silence the warning and guard against future refactors.