Add option to attach an adapter in valkeyAsyncConnectWithOptions()#331
Open
bjosv wants to merge 2 commits into
Open
Add option to attach an adapter in valkeyAsyncConnectWithOptions()#331bjosv wants to merge 2 commits into
bjosv wants to merge 2 commits into
Conversation
Add attach_fn and attach_data to valkeyOptions, allowing the event-loop adapter to be specified as part of the connection options. When set, valkeyAsyncConnectWithOptions() attaches the adapter and registers the fd with the event loop internally. For TCP connections, connect is deferred past context initialization to ensure the context is fully set up before the connect call. The adapter receives a valid fd and works without modification. This mirrors the existing cluster API pattern (valkeyClusterOptions) and enables future work where the adapter drives non-blocking DNS resolution. The legacy path (attaching the adapter separately after connect) remains fully supported. Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
michael-grunder
approved these changes
Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
attach_fnandattach_datatovalkeyOptions, allowing the event-loop adapter to be specified as part of the connection options. When set,valkeyAsyncConnectWithOptions()attaches the adapter internally after the connect is initiated.This mirrors the existing cluster API pattern (
valkeyClusterOptions) and enables future work where the adapter drives non-blocking DNS resolution.The legacy path (attaching the adapter separately after connect) remains fully supported.
Changes
attach_fn/attach_datafields invalkeyOptionsVALKEY_CONNECT_DEFERRED) until after context setup, then DNS + connect runs before adapter attach