Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/neris_api_client/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,8 @@ def _call(
data = model.model_validate_json(data).model_dump(mode="json", by_alias=True)
if isinstance(data, dict):
data = model.model_validate(data).model_dump(mode="json", by_alias=True)
elif isinstance(data, str):
data = json.loads(data)

res = getattr(self._session, method)(
f"{self.config.base_url}{path}", json=data, params=params
Expand Down
40 changes: 40 additions & 0 deletions tests/test_payload_serialization.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
from datetime import datetime
from types import SimpleNamespace
import unittest

from neris_api_client.client import _NerisApiClient


class Response:
def raise_for_status(self):
pass

def json(self):
return {}


class Session:
def __init__(self):
self.headers = {}
self.kwargs = None

def post(self, *args, **kwargs):
self.kwargs = kwargs
return Response()


class PayloadSerializationTests(unittest.TestCase):
def test_json_string_payload_is_sent_as_a_json_object_without_validation(self):
client = object.__new__(_NerisApiClient)
client.config = SimpleNamespace(base_url="https://api.example.test", debug=False, validate=False)
client.tokens = SimpleNamespace(access_token="token", expires_at=datetime.max)
client._session = Session()
client._update_auth = lambda: None

client._call("post", "/entity", data='{"name": "Example Fire Department"}')

self.assertEqual(client._session.kwargs["json"], {"name": "Example Fire Department"})


if __name__ == "__main__":
unittest.main()