Repository navigation
Fix/display name - #1305
Open
flashguerdon wants to merge 4 commits into
Open
Fix/display name#1305flashguerdon wants to merge 4 commits into
flashguerdon wants to merge 4 commits into
Conversation
- Add support for preferred_username claim in display name generation - Make OIDC preferred_username claim field names configurable per IdP - Refactor to reduce repetition when fetching IdP config - Update post_login to check preferred_username before falling back to email/names This allows IdPs to set user-friendly display names (e.g., "john.smith") via the preferred_username claim, improving UX over email addresses. Fallback hierarchy: preferred_username → email → "firstname lastname" → username
Avantol13
requested changes
Apr 29, 2026
Avantol13
left a comment
Avantol13
left a comment
Contributor
There was a problem hiding this comment.
Can you add some unit tests for this?
| or (token_result.get(email_claim_field) or "").lower() \ | ||
| or " ".join(filter(None, [token_result.get(firstname_claim_field), token_result.get(lastname_claim_field)])).strip() | ||
|
|
||
| user.display_name = preferred_username or user.username # final fallback |
Contributor
There was a problem hiding this comment.
user could be None based on the function signature so we should protect against that
| # build a friendly label, prefer token preferred_username, then email, then names, then username | ||
| preferred_username = None | ||
| if token_result: | ||
| preferred_username = token_result.get("preferred_username") \ |
Contributor
There was a problem hiding this comment.
use (
)
for multi-lines, not \
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket if there is one:
New Features
Breaking Changes
Bug Fixes
This allows IdPs to set user-friendly display names (e.g., "john.smith")
via the preferred_username claim, improving UX over email addresses.
Fallback hierarchy: preferred_username → email → "firstname lastname" → username
Improvements
Dependency updates
Deployment changes