test(discovery): execute the manifest in dependency order - #71
Open
pengyuzhang wants to merge 1 commit into
Open
test(discovery): execute the manifest in dependency order#71pengyuzhang wants to merge 1 commit into
pengyuzhang wants to merge 1 commit into
Conversation
Two jobs, and the second is the one the scorer depends on. The runner installs what it can, then records - per entry id - what the machine really ended up with. manifest.actual.json, not the manifest, is what scoring compares against: an install that failed, or that a vendor no longer ships here, must never be scored as a miss. Entries are not independent, so execution follows dependency order rather than manifest order. Config sites come after the applications that own them: several MCP declaration sites live inside an application's own config directory, and writing one before the application exists creates a path the collector may treat differently from one the application itself created. Running processes go last, because they have to still be alive at the second scan. An entry whose dependency never installed is recorded unimplemented rather than failed. The entry did not fail; the thing it needed was never there. Scoring it as a miss would blame the collector for the harness's own gap - and a second install of a tool that was never installed once proves nothing about duplication. Canaries are generated once per run and substituted here rather than in each recipe, so a credential exists in exactly one place. A recipe that built its own would plant a value the redaction check never searches for, and the run would report a clean check it never made.
lghupan
approved these changes
Aug 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #70.
Two jobs, and the second is what the scorer depends on. The runner installs what it can, then records per entry id what the machine really ended up with.
manifest.actual.json, not the manifest, is what scoring compares against — an install that failed, or that a vendor no longer ships here, must never be scored as a miss.Dependency order, not manifest order
Step 6 after step 3 is the subtle one. Several MCP declaration sites live inside an application's own config directory, and writing
M-SITE-08before JetBrains exists creates a path the collector may treat differently from one the application itself created.Blocked entries are
unimplemented, notfailedThe entry did not fail; the thing it needed was never there. Scoring it as a miss would blame the collector for the harness's own gap — and a second install of a tool that was never installed once proves nothing about duplication.
Canaries are substituted in one place
Generated once per run, applied here rather than in each recipe, so a credential exists in exactly one place: the run directory. A recipe that built its own would plant a value the redaction check never searches for, and the run would report a clean check it never made.
Verification
Dry guest, all three platforms:
The one Windows failure is a real finding, left visible
N-09is specified as a dangling symlink at/usr/local/bin/claude-oldand marked applicable on all three platforms, but that path is POSIX-only — the entry cannot exist on Windows as written. Every other per-OS path in the manifest is a three-way mapping; this one is a bare string, inherited from the way the row is written intests/README.md.It is left failing rather than papered over, because the failure is the harness correctly reporting that it could not do what it was asked. Fixing it means deciding what the Windows equivalent is — a broken shortcut on
PATH, most likely — which is a manifest change and belongs with the Windows work, where it can actually be validated. Windows is unvalidated in this series either way; see #68 on why no QEMU driver ships here.Live results
These recipes, this runner, against a real Ubuntu 24.04 aarch64 guest:
Verified on the guest rather than from the runner's own report: 8 CLI binaries on
PATHat their pinned versions, 12/12 config sites written,/etc/claude-code/managed-settings.jsonownedroot:root,N-09's link present and dangling, 28 artifact files.