Repository navigation
Conversation
For each attribute, `html_attr()` passed the value through `htmlAttrValue()`, which returns a string unchanged, and escaped the attribute name again although names repeat (`class`, `id`). String values now skip `htmlAttrValue()`, and escaped names are remembered per charset (at most 1,000 per charset). 4 string attributes go from 3521-3772 -> 1609-1947 ns, and 6 mixed attributes from 6223-8056 -> 4104-6152 ns. Caveat: the memo uses `$env->getCharset()`, so calling `setCharset()` after the escaper runtime was created could make them differ.
Contributor
Author
|
FYI we used the same "trick" to check for string values before calling for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For each attribute,
html_attr()passed the value throughhtmlAttrValue(), which returns a string unchanged, and escaped the attribute name again although names repeat (class,id).String values now skip
htmlAttrValue(), and escaped names are remembered per charset (at most 1,000 per charset).4 string attributes go from 3521-3772 -> 1609-1947 ns, and 6 mixed attributes from 6223-8056 -> 4104-6152 ns. Caveat: the memo uses
$env->getCharset(), so callingsetCharset()after the escaper runtime was created could make them differ.