Repository navigation
Conversation
With a `NumberFormatter` prototype, every `format_number` call read 45 attributes, text attributes and symbols from the prototype, then set all 45 again on the formatter it had just taken from its cache. The prototype is now read once, and a formatter is configured only when it is created (everything set is part of its cache key). `format_number` with a prototype goes from 49.7-55.3 -> 4.0-4.3 µs, and without one from 842-1162 -> 742-773 ns. Caveat: a prototype changed after the extension was constructed is no longer read again.
nicolas-grekas
approved these changes
Nov 15, 2026
nicolas-grekas
left a comment
Contributor
There was a problem hiding this comment.
another optim could be to make the caching props static, for worker mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With a
NumberFormatterprototype, everyformat_numbercall read 45 attributes, text attributes and symbols from the prototype, then set all 45 again on the formatter it had just taken from its cache.The prototype is now read once, and a formatter is configured only when it is created (everything set is part of its cache key).
format_numberwith a prototype goes from 49.7-55.3 -> 4.0-4.3 µs, and without one from 842-1162 -> 742-773 ns. Caveat: a prototype changed after the extension was constructed is no longer read again.