Repository navigation
Conversation
…t need to know whether the sandbox is enabled Each call site of a callable declared with `needs_is_sandboxed` compiled to `$this->env->hasExtension(SandboxExtension::class) && ...->isSandboxed($this->source)`, so `hasExtension()` ran on every call even without the sandbox. The registered extensions are part of the compiled template cache key, so the compiler now writes `false` when the sandbox extension is not registered, and only the `isSandboxed()` call when it is. `GetAttrExpression` already relies on the same fact, and this changes the generated code. A template with 600 such calls goes from 0.479-0.492 -> 0.407-0.437 ms per render, with no measurable change on a template with 4 calls.
nicolas-grekas
approved these changes
Nov 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each call site of a callable declared with
needs_is_sandboxedcompiled to$this->env->hasExtension(SandboxExtension::class) && ...->isSandboxed($this->source), sohasExtension()ran on every call even without the sandbox.The registered extensions are part of the compiled template cache key, so the compiler now writes
falsewhen the sandbox extension is not registered, and only theisSandboxed()call when it is.GetAttrExpressionalready relies on the same fact, and this changes the generated code.A template with 600 such calls goes from 0.479-0.492 -> 0.407-0.437 ms per render, with no measurable change on a template with 4 calls.