fix(kconfig): missing endif in ESP32 Kconfig breaks all board builds - #683
Merged
adwuard merged 1 commit intoAug 20, 2026
Merged
Conversation
yingtao450
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
boards/ESP32/Kconfig's XTEINK_X4_PRO choice entry (added in #682) is missing the closing endif that every other entry in this choice block has, causing Kconfig parsing to fail with
couldn't parse 'endchoice': no corresponding 'choice'-- this blocks building ANY board, not just ESP32 ones. One-line fix, matches the sibling XTEINK_X4 entry's structure.