fix(post-processing): remove zero-length segments left by diagonal fix#456
Open
theherrovn-sys wants to merge 1 commit into
Open
Conversation
Closes tscircuit#78 Root cause: when TraceOverlapShiftSolver.findAndFixNextDiagonalSegment fixes a near-zero diagonal segment it inserts an elbowPoint via splice(). If the chosen elbow coincides with the adjacent endpoint (p1 or p2), a zero-length segment is produced. simplifyPath did not remove duplicate consecutive points, so the spurious segment survived into final output. Fix 1 - simplifyPath.ts: add isSamePoint() guard that drops zero-length (duplicate) points in both simplification passes. Fix 2 - TraceOverlapShiftSolver.ts: before splice(), detect when the elbow equals p1 or p2 and snap the existing endpoint instead of inserting a duplicate.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #78
/claim #78
Root cause: when TraceOverlapShiftSolver.findAndFixNextDiagonalSegment
fixes a near-zero diagonal segment it inserts an elbowPoint via splice().
If the chosen elbow coincides with the adjacent endpoint (p1 or p2), a
zero-length segment is produced. simplifyPath did not remove duplicate
consecutive points, so the spurious segment survived into final output.
Fix 1 - simplifyPath.ts: add isSamePoint() guard that drops zero-length
(duplicate) points in both simplification passes.
Fix 2 - TraceOverlapShiftSolver.ts: before splice(), detect when the
elbow equals p1 or p2 and snap the existing endpoint instead of
inserting a duplicate.