Repository navigation
Implement initial and max usage timer for PIN tokens - #78
Merged
Merged
Conversation
robin-nitrokey
force-pushed
the
token-timers
branch
from
October 28, 2026 12:43
320f4d5 to
d581ef0
Compare
Merged
sosthene-nitrokey
approved these changes
Oct 28, 2026
This follows the behavior specified in § 6.5.2.1 of the spec.
robin-nitrokey
force-pushed
the
token-timers
branch
from
October 28, 2026 13:51
d581ef0 to
6a95d44
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows the behavior specified in § 6.5.2.1 of the spec.
One important point to mention is that I chose a constant initial usage time limit of 19 seconds for all transports. The spec mandates at most 30 seconds for USB and at most 19.8 seconds for NFC and smart-card transports. 19 seconds thus complies with the spec, should still be enough for all real-world application and removes the need to keep track of the transport of the current request.
Depends on trussed-dev/trussed#238 for the tests.