Skip to content

docs(flaky-tests): document fork PR uploads via public repo identifier#35

Merged
samgutentag merged 1 commit into
mainfrom
sam-gutentag/fork-pr-uploads-flaky-tests
Jun 1, 2026
Merged

docs(flaky-tests): document fork PR uploads via public repo identifier#35
samgutentag merged 1 commit into
mainfrom
sam-gutentag/fork-pr-uploads-flaky-tests

Conversation

@samgutentag

@samgutentag samgutentag commented May 19, 2026

Copy link
Copy Markdown
Member

Summary

Adds a new section to the Multiple Repositories and Forks page explaining how to upload test results from GitHub Actions fork PR workflows that cannot access org secrets.

The new section covers:

  • Why fork PR workflows cannot use $TRUNK_API_TOKEN
  • How to enable fork PR uploads in repository settings
  • How to use the public repo identifier in GitHub Actions YAML
  • How the authorization model works

Source

Test plan

  • Check Mintlify preview link (posted on the PR by the Mintlify GitHub app)

Generated by Claude Code

@mintlify

mintlify Bot commented May 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
trunk 🟢 Ready View Preview May 19, 2026, 6:19 PM

@samgutentag Claude

samgutentag commented May 19, 2026

Copy link
Copy Markdown
Member Author

Verification status (May 19, 2026): pending

Eng merged but feature is not end-to-end functional for customers yet.

  • Eng PR: https://github.com/trunk-io/trunk2/pull/3908
  • Flag: none (no feature flag found)
  • Signals:
    • trunk2#3908 merged May 18, 2026
    • Backend (legacy monolith accepting X-Trunk-Public-Repo-Id) not yet implemented (explicit out-of-scope in PR description)
    • analytics-cli support for --public-repo-id flag not yet added (explicit out-of-scope)
    • Frontend settings UI toggle is live, but the upload path is incomplete

Hold off on publishing. Re-check after the monolith and analytics-cli cross-repo TODOs are completed.

Generated by Claude Code

@samgutentag samgutentag changed the title docs(flaky-tests): document fork PR uploads via public repo identifier [feature not live] docs(flaky-tests): document fork PR uploads via public repo identifier May 19, 2026
@samgutentag samgutentag added the awaiting eng Verify docs PR: eng PR not merged. Hold. label May 19, 2026
@samgutentag samgutentag changed the title [feature not live] docs(flaky-tests): document fork PR uploads via public repo identifier docs(flaky-tests): document fork PR uploads via public repo identifier May 19, 2026
@samgutentag samgutentag mentioned this pull request May 19, 2026
Merged
3 tasks
@samgutentag

samgutentag commented May 19, 2026

Copy link
Copy Markdown
Member Author

Verification status (2026-05-19): blocked

Eng PR not merged. Hold.

  • Eng PR: trunk2#3908 (merged 2026-05-18). Cross-repo deps still OPEN:
    • analytics-cli#1086 (Support X-Trunk-Public-Repo-Id auth for fork PRs)
    • trunk#31970 (Accept X-Trunk-Public-Repo-Id on flaky-tests upload + quarantine endpoints)
  • Flag: none
  • Signals: same blocker as PR docs(flaky-tests): document fork PR uploads per-repo opt-in #33. The customer workflow (uploading via fork PR with public-repo-id in YAML) is non-functional until analytics-cli ships the header.

Note: PR #33 also documents this feature. The two cover overlapping content; coordinate which to merge.

Label: awaiting eng.

@samgutentag samgutentag mentioned this pull request May 20, 2026
Closed
4 tasks
@samgutentag samgutentag added pending Verify docs PR: eng merged but flag off in prod. Hold off. and removed awaiting eng Verify docs PR: eng PR not merged. Hold. labels May 20, 2026 — with Claude
@samgutentag Claude

samgutentag commented May 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Verification status (2026-05-29): blocked

Eng PR not merged. Hold.

Progress since last sweep: monolith half (trunk#31970) shipped. Remaining blocker is the CLI half (analytics-cli#1101). Hold until #1101 merges.

Note: PR #33 also documents this feature. The two cover overlapping content; coordinate which to merge.

Label: awaiting eng.

@samgutentag samgutentag added awaiting eng Verify docs PR: eng PR not merged. Hold. and removed pending Verify docs PR: eng merged but flag off in prod. Hold off. labels May 26, 2026
@samgutentag samgutentag force-pushed the sam-gutentag/fork-pr-uploads-flaky-tests branch from b2cec77 to 5d74aad Compare May 26, 2026 20:09
@samgutentag samgutentag added ready to merge Verify docs PR: customers can use this. Ready to publish. and removed awaiting eng Verify docs PR: eng PR not merged. Hold. labels May 30, 2026 — with Claude
@samgutentag Claude

samgutentag commented May 30, 2026

Copy link
Copy Markdown
Member Author

Verification status (May 30, 2026): live

Verified: customers can use this. Ready to publish.

  • Flag state: LaunchDarkly not consulted (no flag gates this feature).
  • Eng PR: trunk-io/trunk2#3908 (merged 2026-05-18, intact on main), trunk-io/trunk#31970 (merged 2026-05-28), Support uploading from forked-repo PRs via x-trunk-public-repo-id analytics-cli#1101 (merged 2026-05-29).
  • Flag: none.
  • Signals: Slack #merge-notifications confirmed analytics-cli#1101 "Support uploading from forked-repo PRs via x-trunk-public-repo-id" merged 2026-05-29 at 11:48 PDT. The prior blockers (CLI not sending the header, monolith not accepting it) are both resolved.

Prior verdict was blocked because analytics-cli#1101 was still open. It merged yesterday. The complete fork PR upload path is now live in production. Note: PR #33 also documents this feature with overlapping content on the same page. Coordinate before publishing.

Generated by Claude Code

@samgutentag Claude

samgutentag commented May 31, 2026

Copy link
Copy Markdown
Member Author

Verification status (May 31, 2026): live

The blocking analytics-cli dependency has merged; fork PR upload docs (identifier flow) are clear to ship.

  • Flag state: not consulted
  • Eng PRs: trunk2#3908 (merged May 18), trunk#31970 (merged May 28), analytics-cli#1101 (merged May 29)
  • Flag: none
  • Signals: all three cross-repo blocking PRs landed; feature live in prod since May 30

Next action: merge this PR.

Generated by Claude Code

@samgutentag Claude

samgutentag commented Jun 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Verification status (2026-06-01): live

Verified: customers can use this. Ready to publish.

  • Flag state: LaunchDarkly not consulted (feature is ungated; no LaunchDarkly flag in trunk2#3908).
  • Eng PRs: trunk-io/trunk2#3908 (merged 2026-05-18), trunk-io/trunk#31970 (merged 2026-05-28), Support uploading from forked-repo PRs via x-trunk-public-repo-id analytics-cli#1101 (merged 2026-05-29). All three merge commits confirmed intact on main this sweep.
  • Flag: none.
  • Signals: the full fork PR upload path (frontend toggle + monolith accepting X-Trunk-Public-Repo-Id + CLI sending it) is complete. No new blockers.

Unchanged from prior sweep: still live. PR is currently CONFLICTING (needs rebase) but rollout/content state is unaffected. Note: PR #33 documents overlapping content on the same page; coordinate before publishing.

Generated by Claude Code

@samgutentag samgutentag force-pushed the sam-gutentag/fork-pr-uploads-flaky-tests branch from 5d74aad to 133d4da Compare June 1, 2026 20:32
@samgutentag @claude
docs(flaky-tests): reconcile fork PR uploads section, fix identifier …
ea718eb 
…rotation

Merges #35's fuller content into the section #33 added to main, leaving one
fork-PR section instead of two overlapping ones. Adds the why (fork
pull_request workflows run read-only and can't read secrets), the public vs
private guidance, and a raw-CLI alternative (--public-repo-id /
TRUNK_PUBLIC_REPO_ID, sent on the X-Trunk-Public-Repo-Id header).

Fixes the rotation claim: the prior <Warning> said re-enabling mints a new
identifier and invalidates the old one. Source (frontend
fork-pr-uploads.ts upsert) only generates publicRepoIdentifier on row
create; the enable/disable update never touches it, so the identifier
persists and is reused on re-enable. Verified the action input
(analytics-uploader action.yaml: public-repo-id) and CLI flag
(analytics-cli upload_command.rs: public_repo_id) both exist.

Drops #### subheadings for bold-lead paragraphs to keep the page at h3.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@samgutentag samgutentag force-pushed the sam-gutentag/fork-pr-uploads-flaky-tests branch from 133d4da to ea718eb Compare June 1, 2026 20:58
@samgutentag samgutentag marked this pull request as ready for review June 1, 2026 20:58
@samgutentag samgutentag merged commit f466fc5 into main Jun 1, 2026
2 checks passed
@samgutentag samgutentag deleted the sam-gutentag/fork-pr-uploads-flaky-tests branch June 1, 2026 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ready to merge Verify docs PR: customers can use this. Ready to publish.

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@samgutentag