Skip to content

docs(changelog): merge queue failure statuses and merge item IDs on test runs#147

Merged
samgutentag merged 1 commit into
mainfrom
sam-gutentag/changelog-merge-queue-failure-statuses-merge-item-ids
May 29, 2026
Merged

docs(changelog): merge queue failure statuses and merge item IDs on test runs#147
samgutentag merged 1 commit into
mainfrom
sam-gutentag/changelog-merge-queue-failure-statuses-merge-item-ids

Conversation

@samgutentag
Copy link
Copy Markdown
Member

What shipped

The merge queue testing details API now reports which PRs a merge item is waiting on when tests pass, and records the specific failure status on the test run when tests fail — replacing a generic "tests failed" with precise failure attribution.

  • Source eng PR: trunk-io/trunk2#3727 ("Add merge item IDs to test passed details, and add failure statuses to test runs")
  • Linear: TRUNK-18135 (no absorbed duplicates)
  • Date basis: trunk2#3727 mergedAt = 2026-04-28

Wired into all four sites

  1. changelog/2026-04-28-merge-queue-failure-statuses-merge-item-ids.mdx (entry)
  2. docs.json — added to the Changelog 2026 group, newest-first
  3. changelog/index.mdx<Update> block in the April 2026 section
  4. merge-queue/changelog.mdx — same <Update> block in the April 2026 section

Docs link target: /merge-queue/reference/merge/get-details-about-testing-that-merge-queue-is-performing (the auto-generated getMergeQueueTestingDetails endpoint page).

🤖 Generated with Claude Code

@mintlify
Copy link
Copy Markdown
Contributor

mintlify Bot commented May 29, 2026

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
trunk 🟢 Ready View Preview May 29, 2026, 5:28 AM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@samgutentag samgutentag added changelog PR touches the changelog (auto-generated drafts, hosting, formatting, indexing). ready to merge Verify docs PR: customers can use this. Ready to publish. labels May 29, 2026
@samgutentag
Copy link
Copy Markdown
Member Author

Verification status (2026-05-28): live

Verified: customers can use this. Ready to publish.

  • Eng PR: trunk-io/trunk2#3727 (MERGED 2026-04-28, merge commit on main)
  • Flag: none (ships via a Prisma DB migration 20260423185013_add_test_fail_and_pass_details, no LaunchDarkly gating)
  • Signals: eng PR merged and merge commit still on main (compare status behind); diff adds MergeItemTestsPassedDetails and failure-status fields to TestRun, matching the changelog copy; no feature-flag references in body or diff, so nothing to roll out behind a flag.

No action needed. Kept as draft pending Sam's review per the changelog workflow.

@samgutentag
Copy link
Copy Markdown
Member Author

Code verification (2026-05-28): 2 confirmed / 0 contradicted / 0 ambiguous / 0 unverifiable

Claim Verdict Source
Test-passed details record the merge items the item is waiting on confirmed migration.sql:2
Failed test runs record the specific failure status confirmed migration.sql:5

Both claims map to real columns added by the migration in trunk2#3727. The entry is intentionally prose-only (no field names asserted), so there is nothing to correct.


Source #1 — merge items the item is waiting on (confirmed)

File: trunk-io/trunk2/ts/packages/prisma/servicesDb/migrations/20260423185013_add_test_fail_and_pass_details/migration.sql#L2

ALTER TABLE "merge_item_tests_passed_details" ADD COLUMN     "waiting_for_merge_item_ids" TEXT[] DEFAULT ARRAY[]::TEXT[];

Reasoning: The migration adds waiting_for_merge_item_ids (a TEXT array) to the merge_item_tests_passed_details table. This is exactly the "which merge items the item is waiting on when tests pass" data the changelog describes. The eng PR body confirms the intent: "When tests on a merge item Pass, we can then say what PRs the merge item is currently waiting on to finish testing before trying to merge or getting restarted." The column also surfaces in the generated MergeItemTestsPassedDetails model.

Source #2 — specific failure status on the test run (confirmed)

File: trunk-io/trunk2/ts/packages/prisma/servicesDb/migrations/20260423185013_add_test_fail_and_pass_details/migration.sql#L5

ALTER TABLE "test_run" ADD COLUMN     "failure_causing_statuses" TEXT[] DEFAULT ARRAY[]::TEXT[];

Reasoning: The migration adds failure_causing_statuses (a TEXT array) to the test_run table, surfaced as failureCausingStatuses in the generated TestRun Prisma model. This is the "specific failure status recorded directly on the test run" the changelog describes, replacing a generic "tests failed". The eng PR body confirms: "When tests on a merge item Fail, we can record that status directly then be able to say, instead of 'tests failed', what actually failed and caused the transition."

@samgutentag samgutentag added the code-verified verify-docs-against-code: all factual claims confirmed in source. label May 29, 2026
@samgutentag samgutentag marked this pull request as ready for review May 29, 2026 06:11
…est runs

Documents the testing details API improvement: test-passed details now
include the merge item IDs an item is waiting on, and failed test runs
record a specific failure status instead of a generic "tests failed".

Source eng PR: trunk-io/trunk2#3727 (merged 2026-04-28)
Linear: TRUNK-18135
Date basis: trunk2#3727 mergedAt (2026-04-28).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@samgutentag samgutentag force-pushed the sam-gutentag/changelog-merge-queue-failure-statuses-merge-item-ids branch from 2d0e1b6 to d35586f Compare May 29, 2026 06:11
@samgutentag samgutentag merged commit e644be5 into main May 29, 2026
3 checks passed
@samgutentag samgutentag deleted the sam-gutentag/changelog-merge-queue-failure-statuses-merge-item-ids branch May 29, 2026 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog PR touches the changelog (auto-generated drafts, hosting, formatting, indexing). code-verified verify-docs-against-code: all factual claims confirmed in source. ready to merge Verify docs PR: customers can use this. Ready to publish.

Development

Successfully merging this pull request may close these issues.

1 participant