docs(flaky-tests): publish Test Collections page + changelog entry#137
docs(flaky-tests): publish Test Collections page + changelog entry#137samgutentag wants to merge 2 commits into
Conversation
Unhide and wire the existing Test Collections page into the Get Started nav, fix duplicated tab bullets, and add a collection-level quarantining section linking to the quarantining docs. Add a Test Collections changelog entry (2026-04-22, GA via v160) wired into all four surfaces: the .mdx file, docs.json changelog nav, changelog/index.mdx, and the Flaky Tests changelog index. Source: TRUNK-18209; trunk2 #3583/#3598/#3660/#3678. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
…n-short-id verify-docs-against-code: the analytics-cli uploader arg is `--test-collection-short-id` (env TRUNK_TEST_COLLECTION_SHORT_ID), derived from the clap field; there is no `--collection` flag. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Code verification (2026-05-29): 3 confirmed / 1 contradicted / 0 ambiguous / 1 unverifiable
Action taken: the CLI flag was Source #1 — CLI upload flag (contradicted, corrected)File: #[arg(
long,
env = constants::TRUNK_TEST_COLLECTION_SHORT_ID_ENV,
help = "Optional test collection short ID to attach to the uploaded bundle for collection-aware ingestion.",
required = false,
num_args = 1
)]
pub test_collection_short_id: Option<String>,Reasoning: clap's Source #3 — admin-only management (confirmed)File: const { data: adminData } = useQuery(GetCurrentUserIsAdminForDeleteCollectionDocument, ...);
const isAdmin = adminData?.currentUserIsAdmin ?? false;
...
disabled={!isAdmin}
...
Only organization admins can delete collectionsReasoning: the destructive action is gated on Source #5 — tabs disabled until upload (confirmed)File: label="Tests"
disabled={testsTab === "DISABLED"}
isActive={isActive("tests")}Reasoning: the Tests (and Uploads) tabs render with |
|
Verification status (2026-05-29): Eng merged but the feature owner says it is not ready for customers. Hold off.
Next: keep in draft. Confirm with @dfrankland what remains before GA, then re-run. Note the chained |
|
Not ready to go live yet :) |
|
Verification status (May 31, 2026): The code is unguarded, but the eng author has explicitly asked to hold off on going live.
Next action: wait for @dfrankland to give the go-ahead, then merge. Generated by Claude Code |
Summary
Publishes the Test Collections docs (the page existed but was
hidden: true) and adds the matching changelog entry.What changed
flaky-tests/get-started/test-collections.mdx— removedhidden: true, fixed duplicated Tests/Uploads bullets, added a Collection-level quarantining section linking to the quarantining docs.docs.json— added the page to the Get Started nav; added the changelog entry to the changelog nav.changelog/2026-04-22-flaky-tests-test-collections.mdx— new entry, wired intochangelog/index.mdxandflaky-tests/changelog.mdx(new April 2026 section).Live status
GA — verified from trunk2 code: no
showTestCollectionsflag exists, the collections routes/nav helper are unguarded, and the e2e CRUD tests run with no flag-enable step. Shipped v154 (2026-04-16), fully featured (incl. collection quarantining) by v160 (2026-04-22). Changelog dated 2026-04-22 accordingly.Source
Engineering authors
Notes for review
🤖 Generated with Claude Code