Skip to content

Rename --test-collection-short-id flag to --test-collection-id#1118

Open
dfrankland wants to merge 2 commits into
mainfrom
dylan/rename-test-collection-id-flag
Open

Rename --test-collection-short-id flag to --test-collection-id#1118
dfrankland wants to merge 2 commits into
mainfrom
dylan/rename-test-collection-id-flag

Conversation

@dfrankland

@dfrankland dfrankland commented Jun 12, 2026

Copy link
Copy Markdown
Member

Depended on by:

Summary

  • Renames the CLI flag --test-collection-short-id to --test-collection-id
  • Updates the adjoining env var from TRUNK_TEST_COLLECTION_SHORT_ID to TRUNK_TEST_COLLECTION_ID
  • Updates flag description to "Optional 8 character alphanumeric ID for a test collection."
  • Internal field names (test_collection_short_id, shortId) are unchanged

Test plan

  • Smoke tests pass with updated flag name in CI

🤖 Generated with Claude Code

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@trunk-io

trunk-io Bot commented Jun 12, 2026

Copy link
Copy Markdown

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

@trunk-staging-io

trunk-staging-io Bot commented Jun 12, 2026

Copy link
Copy Markdown

Static BadgeStatic BadgeStatic BadgeStatic Badge

Failed Test Failure Summary Logs
variant_quarantine_test should be quarantined when run with variant A test expected the sum of 2 + 2 to be 5, but it was 4, indicating a failing assertion. Logs ↗︎

View Full Report ↗︎Docs

@codecov-commenter

codecov-commenter commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.64%. Comparing base (93220ba) to head (da45249).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1118      +/-   ##
==========================================
+ Coverage   82.39%   82.64%   +0.24%     
==========================================
  Files          69       69              
  Lines       15397    15399       +2     
==========================================
+ Hits        12687    12726      +39     
+ Misses       2710     2673      -37     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@trunk-io

trunk-io Bot commented Jun 12, 2026

Copy link
Copy Markdown

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@EliSchleifer EliSchleifer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So shrt

- Rename TRUNK_TEST_COLLECTION_SHORT_ID_ENV constant to TRUNK_TEST_COLLECTION_ID_ENV
- Read TRUNK_TEST_COLLECTION_ID env var in Ruby gem publish
- Add test-collection-id input to test_ruby_gem_uploads action
- Wire staging (T5yKSn9h) and prod (BiBP2neA) collection IDs into workflows

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants