feat: Add config-manager push journeys command - #92
Closed
dallinjsevy wants to merge 1 commit into
Closed
Conversation
dallinjsevy
force-pushed
the
feature/config-manager-push-journeys
branch
from
April 6, 2026 15:27
1c25c4a to
27bf7e8
Compare
dallinjsevy
force-pushed
the
feature/config-manager-push-journeys
branch
from
May 26, 2026 20:12
27bf7e8 to
c00dc2a
Compare
hfranklin
reviewed
May 30, 2026
hfranklin
reviewed
May 30, 2026
hfranklin
reviewed
May 30, 2026
hfranklin
reviewed
May 30, 2026
phalestrivir
requested changes
Jul 10, 2026
phalestrivir
requested changes
Jul 23, 2026
There was a problem hiding this comment.
Note that I did push a commit with some refactoring I did to the exports since you are already making fixes to it in this PR, so I think we'll include the refactoring for it as well as part of the changes so we don't have to create a separate PR for it. Make sure to pull the changes before you make any changes or rebase.
dallinjsevy
force-pushed
the
feature/config-manager-push-journeys
branch
from
July 23, 2026 20:50
bfa535b to
68aeb16
Compare
phalestrivir
force-pushed
the
feature/config-manager-push-journeys
branch
from
July 23, 2026 20:54
68aeb16 to
bfa535b
Compare
dallinjsevy
force-pushed
the
feature/config-manager-push-journeys
branch
from
July 24, 2026 16:25
bfa535b to
dc1f073
Compare
phalestrivir
requested changes
Jul 27, 2026
phalestrivir
left a comment
phalestrivir
left a comment
There was a problem hiding this comment.
Just a few mostly minor things that need to be fixed
phalestrivir
approved these changes
Jul 28, 2026
phalestrivir
left a comment
phalestrivir
left a comment
There was a problem hiding this comment.
Make the last change I mentioned in the comment below, then make sure to run lint as there's a lint fix that needs to be made, then squash your commits, rebase with main, and run npm run test:update to make sure snapshots and tests are passing before submitting to Rockcarver.
In your description of the PR, I would mention that you had to modify authentication ops so tests wouldn't fail due to there now being a root realm directory in the test export directory. I would also mention that we made a few fixes to the journey pull command to allow for exporting root realm.
dallinjsevy
force-pushed
the
feature/config-manager-push-journeys
branch
2 times, most recently
from
August 3, 2026 20:13
b5a9431 to
413e59e
Compare
dallinjsevy
force-pushed
the
feature/config-manager-push-journeys
branch
from
August 3, 2026 20:13
413e59e to
b50a891
Compare
|
PR created against Rockcarver |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.