Any-Latin; Latin-ASCII in replace_non_ascii()#71
Open
dustinstoltz wants to merge 1 commit intotrinker:masterfrom
Open
Any-Latin; Latin-ASCII in replace_non_ascii()#71dustinstoltz wants to merge 1 commit intotrinker:masterfrom
dustinstoltz wants to merge 1 commit intotrinker:masterfrom
Conversation
… scripts Fixes trinker#64 Previously, replace_non_ascii() used stri_trans_general(x, 'latin-ascii'), which only transliterated Latin-script characters. Non-Latin scripts (Cyrillic, CJK, Devanagari, etc.) were either left as byte sequences or stripped entirely by remove.nonconverted. Now uses 'Any-Latin; Latin-ASCII' to first transliterate any script to Latin, then Latin to ASCII. This is backwards compatible since Any-Latin is a no-op for already-Latin input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… scripts
Fixes #64
Previously, replace_non_ascii() used stri_trans_general(x, 'latin-ascii'), which only transliterated Latin-script characters. Non-Latin scripts (Cyrillic, CJK, Devanagari, etc.) were either left as byte sequences or stripped entirely by remove.nonconverted.
Now uses 'Any-Latin; Latin-ASCII' to first transliterate any script to Latin, then Latin to ASCII. This is backwards compatible since Any-Latin is a no-op for already-Latin input.