Skip to content

cmd/mtc/mirror: respond with 200 OK when nextEntry >= uploadEnd #1200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
phbnf wants to merge 1 commit into
base: main
Choose a base branch
from
Open

cmd/mtc/mirror: respond with 200 OK when nextEntry >= uploadEnd #1200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/mtc/mirror/internal/handler/handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ func addEntries(m *MirrorMux) http.HandlerFunc {
http.Error(w, "Failed to add entries", http.StatusInternalServerError)
return

case nextEntry == pendingSize:
case nextEntry >= req.uploadEnd:
// SPEC: If next_entry == upload_end, and no cosignatures are provided by the mirror,
// the mirror MUST respond with a "200 OK" status code and an empty response body.
// If next_entry == upload_end, and cosignatures are provided by the mirror,
Expand Down
10 changes: 10 additions & 0 deletions cmd/mtc/mirror/internal/handler/handler_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,16 @@ func TestAddEntries_StatusCodes(t *testing.T) {
},
wantStatus: http.StatusOK,
wantBody: testCosig,
}, {
name: "200 ok (uploadEnd reached before pendingSize)",
origin: testOrigin,
mockTarget: &mockTarget{
addEntriesFunc: func(ctx context.Context, uploadStart, uploadEnd uint64, ticket []byte, next func() (*tessera.MirrorPackage, error)) (uint64, uint64, []byte, []byte, error) {
return testUploadEnd, testPendingSize, []byte(testNewTicket), nil, nil
},
},
wantStatus: http.StatusOK,
wantBody: "",
}, {
name: "202 partial upload",
origin: testOrigin,
Expand Down
Loading