fix: correct spelling of "implementer" in column.rs comment#4333
Closed
maxtaran2010 wants to merge 1 commit into
Closed
fix: correct spelling of "implementer" in column.rs comment#4333maxtaran2010 wants to merge 1 commit into
maxtaran2010 wants to merge 1 commit into
Conversation
Collaborator
|
"implementor" is an accepted alternative spelling: https://en.wiktionary.org/wiki/implementor Please do not open PRs for spelling fixes unless it's actually misleading to the point of having negative value on reading the code. It is not a good use of my time to review these. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a minor spelling error in a code comment in
sqlx-core/src/column.rs.implementor→implementer(the correct standard English spelling)This is a one-line comment on the
Column::origin()method explaining why it returns an owned value.