Skip to content

Answer:8 - refactor heavy computation to pure pipe - #1558

Open
IrynOoi wants to merge 1 commit into
tomalaforge:mainfrom
IrynOoi:feat/challenge-2
Open

IrynOoi wants to merge 1 commit into
tomalaforge:mainfrom
IrynOoi:feat/challenge-2

Conversation

@IrynOoi

@IrynOoi IrynOoi commented Sep 25, 2026 •

Copy link
Copy Markdown

✅ Challenge Submission Checklist

Start your PR title with: Answer:${challenge_number}

⚠️ Important Notice

If you would like personal feedback or a detailed review, please support the project on GitHub:

You can also submit a PR without sponsorship to:

  • Be listed among the answered challenges, or
  • Receive a review from a community member. 🔥

Summary by CodeRabbit

  • Updates
    • The people list now formats each entry with its position, displaying names alongside their index.
    • The example now uses a dedicated formatting step to produce these labels, rather than formatting them directly in the component.

@vercel

vercel Bot commented Sep 25, 2026

Copy link
Copy Markdown

@IrynOoi is attempting to deploy a commit to the tomalaforge's projects Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: c73a8580-1cb9-4d76-88d1-0bec7557446c

📥 Commits

Reviewing files that changed from the base of the PR and between 0deb691 and 42eb04b.

📒 Files selected for processing (4)
  • apps/angular/8-pure-pipe/src/app/app.component.ts
  • apps/angular/8-pure-pipe/src/app/heavy-computation.pipe.ts
  • apps/angular/8-pure-pipe/src/index.html
  • apps/angular/8-pure-pipe/src/main.ts

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

AppComponent now uses a standalone HeavyComputationPipe to format each person with its index. The component uses Default change detection, and its former heavyComputation method implementation is removed.

Changes

Pure Pipe Integration

Layer / File(s) Summary
Pipe implementation and component integration
apps/angular/8-pure-pipe/src/app/heavy-computation.pipe.ts, apps/angular/8-pure-pipe/src/app/app.component.ts, apps/angular/8-pure-pipe/src/index.html, apps/angular/8-pure-pipe/src/main.ts
HeavyComputationPipe logs the name and returns it with the index. AppComponent imports and applies the pipe, changes to Default change detection, and no longer implements heavyComputation. The HTML and main files gain identifying comments.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Refactor

Suggested reviewers: tomalaforge

Merge Risk: ⚪ Minimal · up to 42eb0

No actionable merge-blocking issue is established in the pipe integration or the file-identifying comments; the change appears ready for normal checks.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title starts with "Answer:8" and clearly describes the main change: refactoring heavy computation into a pure pipe.
Description check ✅ Passed The description includes all sections and information required by the repository template, including the challenge checklist and sponsorship options.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Create a new PR

Warning

Some tools did not complete. Review the errors below.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install timed out. The project may have too many dependencies for the sandbox.

Warning

⚠️ This pull request has been flagged as potential spam (promotional) by CodeRabbit slop detection and should be reviewed carefully.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

This branch was successfully deployed

1 active deployment
Preview – angular-challenges — 42eb04bf Deployed Sep 25, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8 exercice simple pipe answer answer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant