Repository navigation
Fix sign-out ownership reset before committed actions - #46
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At an initial or replacement account commit, a pending logout action could be cleared by the later passive owner-reset effect. That erased pending feedback, admitted duplicate actions and suppressed the current owner's failure message. Reset ownership in the layout phase so it is settled before the committed controls can be used. The product change is two lines; same-account session renewal and stale-owner completion behavior stay covered.
Validation: a phase-controlled probe against the unchanged hook passes all seven existing controls and fails all seven new regressions. The exact same private 14-case source passes after the minimal fix. The committed regression adaptation and six existing actual-SDK logout UI cases pass all 20 cases on Node 20.20.2. Types, scoped lint and original-config production build pass. Six freshly compiled desktop/mobile browser cases pass once with zero retries; four actual failure/retry captures are verified against published exact-head bytes. A mismatched disposable build hostname caused an earlier six-case failure before sign-out; that separate harness failure is preserved.. The earlier combined 981-pass/one-failure run remains preserved; its exact chronology was not instrumented, so it is consistent with this proven race rather than uniquely attributed to it. Full exact-head CI is required before merge into
v0.8.These are actual compiled disposable SDK transport fixtures, showing retained Account failure feedback and explicit retry. They do not sign out a human production account.
Controlled source/evidence receipt · Compiled browser receipt.