Repository navigation
Add native DeepSeek Harness target and read-only refactor edit plans - #1101
Open
sumingwang233 wants to merge 9 commits into
Open
sumingwang233 wants to merge 9 commits into
sumingwang233 wants to merge 9 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1100.
DeepSeek Harness needs a native bundle to retain Agent-local tool selection,
its workspace graph sidebar, and permission-controlled refactor writes. This
adds the
dshplatform target and delegates installation/removal to DSH's nativeplugin manager. The adapter is maintained separately at
https://github.com/sumingwang233/dsh-code-review-graph, targeting CRG 2.3.9 and
the exact DSH releases 0.1.5-rc.2 and 0.2.0-rc.2. The installer selects
adapter 0.1.2, which adds direct native graph generation, one-click isolated engine
setup and /crg-setup /crg-graph user commands without model inference. It also
retains the native Client factory/sidebar fixes from 0.1.1.
--dsh-profile(defaultweb) to install/init/uninstall. A DSH-only initdoes not install legacy hooks or instruction files. Reinstall leaves an
already registered bundle byte-identical. Removal delegates only this owned
bundle to DSH; malformed manifests and desktop-owned profiles remain intact.
PLATFORMS. DSH stores an npm dependency plusdsh.profile.bundles, so the existing inventory delegates its lifecyclethrough
format="native-bundle"instead of treating it as an MCP object.get_refactor_edit_plan_tool: a read-only, complete edit plan reusing theexisting refactor calculation. It retains previews, checks stale edits, fails
the whole plan for missing/invalid files, preserves BOM/newlines, and includes
original byte hashes. The DSH adapter uses this internal API before submitting
changes through file intents, session policy and
ctx.fs.cached graph paths. This closes a path through a linked parent directory that
adapter argument checks alone cannot protect.
conversion for the vendored asset and accept normalized CRLF bytes only when
the original pinned integrity hash verifies.
before spawning it, so Windows does not select its System32 WSL launcher.
Keep the full large-input assertion; no failure is skipped.
Validation records and release-tagged session transcripts are in the adapter's
docs/validation.mdanddocs/evidence/. They use actual released DSHSession/AgentRegistry/ToolRuntime packages and a real CRG engine with
deterministic calls; no real model inference was run. The graph browser check
executes the published native Client factory with version-specific reader
fixtures. A separate test launches the actual Windows Desktop 0.2.0-rc.2
application and checks native install/enable/remove/reinstall, graph reading,
search and HTML export on both a clean profile and the existing three-plugin
dependency combination. In 0.1.2, each run starts with an empty engine directory;
the native graph button prepares the pinned engine and generates the graph. It preserves unrelated configuration and uses isolated
temporary profiles. Other Desktop releases/platforms have not been tested as
complete applications. The upstream
reviewer decides whether this meets the platform evidence requirement.
Local checks cover native lifecycle, idempotence, malformed configuration,
desktop ownership, all 30 tools/five prompts/seven skills, incremental workers,
authorized cross-repository search, path boundaries, stale edit plans, permission
denial, BOM/CRLF writes, partial-failure recovery, and offline graph interaction, plus native human-command execution and graph-button
failure/cancellation/retry.
Completed GitHub Actions matrices:
Adapter artifacts retain transcripts, browser/lifecycle reports and the tested
packages. The pinned engine retains the same graph/refactor runtime code and
dependencies; later changes adjust CI/test executable resolution and the native
installer's adapter version. Full Web-server launches and actual language-model
or embedding-model inference were not run. The reported pnpm ten-minute timeout
did not reproduce; the adapter does not claim that installer hang is fixed.
See
docs/DSH.mdfor installation, ownership and the edit-plan contract. Untilthis API is released officially, the adapter pins an exact public contribution
fork commit rather than silently relying on a released engine that lacks it.