ipc: Fix ipc_msg_send() with payload already prepared#10717
Open
ujfalusi wants to merge 1 commit intothesofproject:mainfrom
Open
ipc: Fix ipc_msg_send() with payload already prepared#10717ujfalusi wants to merge 1 commit intothesofproject:mainfrom
ujfalusi wants to merge 1 commit intothesofproject:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes ipc_msg_send() so callers can pre-populate msg->tx_data/tx_size and safely call ipc_msg_send(msg, NULL, ...) without triggering a copy attempt from a NULL pointer.
Changes:
- Guard the payload copy in
ipc_msg_send()withdata != NULLto avoidmemcpy_s()fromNULL. - Preserve the “no-copy” path for cases where the payload is already prepared in
msg->tx_data.
tmleman
approved these changes
Apr 23, 2026
If the msg->tx_size/data have been prepared by caller and it calls the function with NULL as data: ipc_msg_send(msg, NULL, false); then we try to copy from NULL to the msg->tx_data because msg->tx_data != data is true. The callers could be fixed as well, but the ipc_msg_send() and ipc_msg_send_direct() should handle this. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
ujfalusi
force-pushed
the
peter/pr/fix_msg_send_with_payload
branch
from
69a7486 to
b057205
Compare
Contributor
Author
|
Changes since v1:
Note: this causes only firmware crash in debug build as assert() is NOP otherwise. |
singalsu
approved these changes
Apr 23, 2026
kv2019i
reviewed
Apr 23, 2026
Collaborator
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
Typo on commit, good otherwise.
| @@ -205,7 +205,7 @@ __cold void ipc_msg_send_direct(struct ipc_msg *msg, void *data) | |||
| key = k_spin_lock(&ipc->lock); | |||
Collaborator
There was a problem hiding this comment.
messagegate sending or message sending?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the msg->tx_size/data have been prepared by caller and it calls the function with NULL as data: ipc_msg_send(msg, NULL, false);
then we try to copy from NULL to the msg->tx_data because msg->tx_data != data is true.
The callers could be fixed as well, but the ipc_msg_send() should handle this.