Repository navigation
Conversation
ekohl
left a comment
There was a problem hiding this comment.
This reads well. Perhaps you could also add an acceptance test that exercises the new code paths? Or would that be too hard?
b144b92 to
c882d2a
Compare
|
Added in c882d2a. The acceptance test applies the S3 configuration twice, verifies the package and generated settings, and runs It is limited to the nightly repository because |
|
I can take a look tomorrow too. I'm using S3, and was doing some bits in my profile code around it, that I was planning to turn into some upstream module patch at some stage. |
alexjfisher
left a comment
There was a problem hiding this comment.
LGTM. I can't see anything I currently have fudged into my profile that couldn't be replaced when this goes into the module.
Install the stable Pulpcore S3 package capability and render Django storage settings when object storage is selected. Preserve filesystem storage by default, keep static assets local, and leave MEDIA_ROOT unset for S3 so Django uses its default. Co-Authored-By: OpenAI Codex (GPT-5.6 Sol High) <noreply@openai.com>
c882d2a to
b16430f
Compare
Summary
Add optional S3-compatible content storage while keeping filesystem storage as the default.
This continues #379 against current
masterand addresses its open review findings:pulpcore-storage-s3capability from theforeman/pulpcore-packaging#3189, which follows thedjango-storagespackaging in #3186;staticfilesbackend socollectstaticcontinues to work;MEDIA_ROOTfor object storage so Django's default empty value applies;storage_optionsis passed through todjango-storages, which supports AWS S3 and S3-compatible endpoints without hard-coding provider-specific options.Verification
bundle exec rake spec: 308 examples, 0 failurespulpcore-manager checkon the nightly repository where the new package is introducedgit diff --checkpassesThis is the installer-side prerequisite for optional object storage in the experimental theforeman/foreman-kubernetes integration.
AI assistance disclosure: OpenAI Codex (GPT-5.6 Sol High).