Repository navigation
chore: extract tims-viewer to its own repository - #451
Merged
Merged
Conversation
tims-viewer now lives at https://github.com/theGreatHerrLebert/tims-viewer (public, MIT), with its full history carried over via `git subtree split` -- 157 of its commits come from this repo, so nothing is lost by removing it here. The extracted copy additionally carries 9 commits that never landed on main: MOBILion .mbi as a second native source, and the R2/R3b/R4 rewiring that moved its dependencies from in-repo paths onto the published ms-io 0.2.0 / mscore 0.5.0 / mobilionmbi 0.1.0 crates. That rewiring is what lets it build outside this workspace at all, and is the reason it makes sense as its own repo: it is an application depending only on published crates, not a member of this monorepo's dependency graph. Removes the crate and both workspace members ("tims-viewer" and "tims-viewer/web"). `cargo metadata` still resolves; nothing else in the workspace referenced it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tims-viewernow lives in its own repository:https://github.com/theGreatHerrLebert/tims-viewer (public, MIT).
Nothing is lost
History was carried over with
git subtree split, not copied — 157 of the newrepo's commits are the ones from this repo. The extracted copy additionally has 9
commits that never landed on
main:.mbias a second native source (3 commits)ms-io 0.2.0/mscore 0.5.0/mobilionmbi 0.1.0Why it belongs outside the monorepo
That rewiring is the point:
tims-vieweris an application whose dependenciesare all published crates. It is not part of this workspace's dependency graph —
nothing here depends on it — so keeping it in-tree only couples an app's release
cycle to the library monorepo. Verified: a clean
cargo build --release --features nativeof the extracted repo succeeds against crates.io alone.What this PR does
Removes
tims-viewer/and both workspace members (tims-viewer,tims-viewer/web).cargo metadatastill resolves cleanly afterwards; no othercrate referenced it.