Skip to content

BridgesList Preferences is an overloaded field #133

Open

Description

@sisbell

BridgesList is an overloaded field, which can cause some confusion. The list can be:

a filter like obfs4 or meek OR  
can be a custom bridge 

For (1), we just pass back all bridges, the filter will occur elsewhere in the library. For (2) we return the bridge list as a raw stream. If length is greater than 5, then we know this is a custom bridge

We should fix this so that we have separate preferences for 1 and 2. We also shouldn't be looking at string length to determine field type.

This tracks with https://trac.torproject.org/projects/tor/ticket/30501

Activity

  1. added a commit that references this issue on Oct 21, 2019
    ac9ad22
  2. added 3 commits that reference this issue on Nov 1, 2019
    d446255
    b72487b
    47b53ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions