Repository navigation
docs(migrate): a Playwright Locator in expect from e2e is a plain value - #1361
Merged
okwasniewski merged 1 commit intoOct 25, 2026
Merged
Conversation
amoscicki
requested review from
okwasniewski and
szymonrybczak
as code owners
October 24, 2026 20:35
Preview approval requiredThis pull request comes from a fork, so Mintlify won't build a preview until someone with write access approves commit |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
No issues found across 1 file
Heads up: you’ve reached your flex budget. Increase your flex budget or wait for usage to reset.
View guided diff | Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
page.getByRole(...)left over from Playwright and passed toexpectfrome2ecompiles to a value expectation, sotoBeVisible()fails withTS2339 ... on type 'ValueExpectation<Locator>', which doesn't say what is wrong.screen.Issue
None (docs).
Verified
Ran it locally: yes
apps/testbedwith itstsconfig.jsonand the built packages:await expect(playwrightLocator).toBeVisible()giveserror TS2339: Property 'toBeVisible' does not exist on type 'ValueExpectation<Locator>'.Checklist
pnpm changeset) for any change to a published package, or the change is testbed, docs, or CI only.!, the changeset body names what breaks and what replaces it, and the deprecation warning landed a window earlier (stability policy in CONTRIBUTING.md).docs/**/*.mdxpage for the behavior, andskills/e2e/if the skill describes it..d.tsreviewed,tests/types/sdk-types.tsupdated; wire change edits the schema and both fixtures.e2e/engine): changesets fore2e,@e2e-dev/web, and@e2e-dev/mobile.Written with AI help (Claude Opus 5.5, OpenAI Sol 6.1, DeepSeek V4.1 Flash); the runs above are real.