fix: distinguish pending Socket STS exchanges from rate limits - #325
Merged
Merged
Conversation
![tempo-voight-kampff[bot]](https://avatars.githubusercontent.com/in/3551435?s=60&v=4){kind=small}
There was a problem hiding this comment.
Approving on behalf of @sds, who approved this pull request (head fa45f1a38707) using the Voight-Kampff Chrome extension.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Socket STS returns HTTP 429 with
exchange is already in progresswhile a retained token creation finishes. The action currently calls this rate limiting, which made normal polling look like throttling in this Aegis job.Recognize that response and log
STS exchange still in progress; waiting 1s for token creation. Retry-budget errors also identify a pending exchange. Actual rate-limit responses retain their existing messages; retry timing and assertion handling are unchanged.Validation:
node --test actions/socket-sts/action.test.jspasses all 36 tests, including pending-exchange logs, provider and non-JSON rate limits, and pending-exchange budget errors.git diff --checkpasses.Refresh the two
actions/attestpins in the extension workflow to the releasedv4.2.2commit with matching version comments. Upstream branch movement made both the scan and integration checks fail with ref-version mismatches. The released version also satisfies the pin verification requirement for a version tag.