chore: ensure local activity replay issue is resolved - #2328
Merged
Merged
Conversation
chris-olszewski
commented
Aug 18, 2026
| - **Experimental**: The external storage S3 and GCS drivers now use `hash_algorithm` and `hash_value` instead of | ||
| `hashAlgorithm` and `hashValue` in their claims. The GCS driver additionally uses `object_name` instead of | ||
| `object`. Retrieval still accepts the old key names. | ||
| - Fixed issue where replaying a workflow with Local Activities scheduled from a nested Promise could |
Member
Author
There was a problem hiding this comment.
Not technically fixed in this PR, but this release will be the first one with this fix
THardy98
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Added regression test for #1744
Why?
Ensure temporalio/sdk-rust#1442 (included first in #2314) resolved #1744
Checklist
Closes [Bug] NDE replaying nested promises #1744 (not really Expose Core console log format #2314 included the core commit that fixed this, but this displays it was fixed)
How was this tested:
Had this history on a branch I created back when I was initially working on this issue. The test now passes.
Just to make sure my past self wasn't doing funny business, I cherry picked this commit to
b802d1a2e15f1d47e01e2b013e966e3fc9f1855a(the commit before the core fix was introduced) and confirmed it failed as expected:N/A