Skip to content

chore: ensure local activity replay issue is resolved - #2328

Merged
chris-olszewski merged 2 commits into
mainfrom
olszewski/fix_nested_promise
Aug 19, 2026
Merged

chris-olszewski merged 2 commits into
mainfrom
olszewski/fix_nested_promise

Conversation

@chris-olszewski

Copy link
Copy Markdown
Member

What was changed

Added regression test for #1744

Why?

Ensure temporalio/sdk-rust#1442 (included first in #2314) resolved #1744

Checklist

  1. Closes [Bug] NDE replaying nested promises #1744 (not really Expose Core console log format #2314 included the core commit that fixed this, but this displays it was fixed)

  2. How was this tested:
    Had this history on a branch I created back when I was initially working on this issue. The test now passes.

Just to make sure my past self wasn't doing funny business, I cherry picked this commit to b802d1a2e15f1d47e01e2b013e966e3fc9f1855a (the commit before the core fix was introduced) and confirmed it failed as expected:

  GH 1744

  Returned promise rejected with:

  DeterminismViolationError {
    message: 'Replay failed with a nondeterminism error. This means that the workflow code as written is not compatible with the history that was fed in. Details: Workflow activation completion failed: Failure { failure: Some(Failure { message: "[TMPRL1100] Nondeterminism error: Activity type of recorded marker \'d\' does not match activity type of local activity command \'c\'", source: "", stack_trace: "", encoded_attributes: None, cause: None, failure_info: Some(ApplicationFailureInfo(ApplicationFailureInfo { r#type: "", non_retryable: false, details: None, next_retry_delay: None, category: Unspecified })) }), force_cause: NonDeterministicError }',
  }
  1. Any docs updates needed?
    N/A

@chris-olszewski
chris-olszewski requested a review from a team as a code owner August 18, 2026 16:47
@chris-olszewski chris-olszewski changed the title add failing test chore: ensure local activity replay issue is resolved Aug 18, 2026
@chris-olszewski
chris-olszewski requested a review from a team as a code owner August 18, 2026 16:58
Comment thread CHANGELOG.md
- **Experimental**: The external storage S3 and GCS drivers now use `hash_algorithm` and `hash_value` instead of
`hashAlgorithm` and `hashValue` in their claims. The GCS driver additionally uses `object_name` instead of
`object`. Retrieval still accepts the old key names.
- Fixed issue where replaying a workflow with Local Activities scheduled from a nested Promise could

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not technically fixed in this PR, but this release will be the first one with this fix

@chris-olszewski
chris-olszewski merged commit ddabbe3 into main Aug 19, 2026
65 of 72 checks passed
@chris-olszewski
chris-olszewski deleted the olszewski/fix_nested_promise branch August 19, 2026 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] NDE replaying nested promises

2 participants