Repository navigation
feat(tracing): add spans for workspace operations - #10864
Closed
Vallabh2909 wants to merge 1 commit into
Closed
Vallabh2909 wants to merge 1 commit into
Vallabh2909 wants to merge 1 commit into
Conversation
Add OpenTelemetry spans to workspace Apply and ValidateBindings functions to improve distributed tracing coverage for workspace operations. Each span includes attributes for the number of workspace bindings and declarations to aid debugging. Part of tektoncd#9790 Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Author
|
/kind feature |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add OpenTelemetry spans to workspace
ApplyandValidateBindingsfunctions to improve distributed tracing coverage for workspace operations. Each span includes attributes for the number of workspace bindings and declarations to aid debugging.Functions that do not currently accept a
context.Contextparameter (CreateVolumes,FindWorkspacesUsedByTask,ValidateOnlyOnePVCIsUsed,ReplaceWorkspaceBindingsVars) are not instrumented in this PR to keep the change small. They can be addressed in a follow-up.Part of #9790
Submitter Checklist
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes
Made with Cursor