fix(pipeline): validate resolver ordinal buckets - #3958
Conversation
Validate the effective resolver bucket count against the rendered StatefulSet replicas after additional options are applied. This prevents ordinal mode from leaving resolver buckets without owners. Signed-off-by: Vibhav Bobade <11972233+waveywaves@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3958 +/- ##
==========================================
+ Coverage 26.33% 26.41% +0.07%
==========================================
Files 465 465
Lines 24951 24979 +28
==========================================
+ Hits 6572 6597 +25
Misses 17661 17661
- Partials 718 721 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Changes
The existing performance documentation already states that buckets must match replicas in ordinal mode.
Fixes #3957.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make test lintbefore submitting a PRSee the contribution guide for more details.
Release Notes