Skip to content

fix(chart): stamp CRD labels with chart appVersion instead of hardcoded devel #3940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aqeelat wants to merge 1 commit into
base: main
Choose a base branch
from
+54 −54
Open

fix(chart): stamp CRD labels with chart appVersion instead of hardcoded devel #3940

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 26 additions & 26 deletions charts/tekton-operator/templates/kubernetes-crds.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ metadata:
controller-gen.kubebuilder.io/version: v0.18.0
name: manualapprovalgates.operator.tekton.dev
labels:
version: "devel"
operator.tekton.dev/release: "devel"
version: {{ .Chart.AppVersion | quote }}
operator.tekton.dev/release: {{ .Chart.AppVersion | quote }}
spec:
group: operator.tekton.dev
names:
Expand Down Expand Up @@ -652,8 +652,8 @@ metadata:
controller-gen.kubebuilder.io/version: v0.18.0
name: openshiftpipelinesascodes.operator.tekton.dev
labels:
version: "devel"
operator.tekton.dev/release: "devel"
version: {{ .Chart.AppVersion | quote }}
operator.tekton.dev/release: {{ .Chart.AppVersion | quote }}
spec:
group: operator.tekton.dev
names:
Expand Down Expand Up @@ -1375,8 +1375,8 @@ metadata:
controller-gen.kubebuilder.io/version: v0.18.0
name: tektonchains.operator.tekton.dev
labels:
version: "devel"
operator.tekton.dev/release: "devel"
version: {{ .Chart.AppVersion | quote }}
operator.tekton.dev/release: {{ .Chart.AppVersion | quote }}
spec:
group: operator.tekton.dev
names:
Expand Down Expand Up @@ -2347,8 +2347,8 @@ metadata:
controller-gen.kubebuilder.io/version: v0.18.0
name: tektonconfigs.operator.tekton.dev
labels:
version: "devel"
operator.tekton.dev/release: "devel"
version: {{ .Chart.AppVersion | quote }}
operator.tekton.dev/release: {{ .Chart.AppVersion | quote }}
spec:
group: operator.tekton.dev
names:
Expand Down Expand Up @@ -4449,8 +4449,8 @@ metadata:
controller-gen.kubebuilder.io/version: v0.18.0
name: tektondashboards.operator.tekton.dev
labels:
version: "devel"
operator.tekton.dev/release: "devel"
version: {{ .Chart.AppVersion | quote }}
operator.tekton.dev/release: {{ .Chart.AppVersion | quote }}
spec:
group: operator.tekton.dev
names:
Expand Down Expand Up @@ -4664,8 +4664,8 @@ metadata:
controller-gen.kubebuilder.io/version: v0.18.0
name: tektoninstallersets.operator.tekton.dev
labels:
version: "devel"
operator.tekton.dev/release: "devel"
version: {{ .Chart.AppVersion | quote }}
operator.tekton.dev/release: {{ .Chart.AppVersion | quote }}
spec:
group: operator.tekton.dev
names:
Expand Down Expand Up @@ -4778,8 +4778,8 @@ metadata:
controller-gen.kubebuilder.io/version: v0.18.0
name: tektonpipelines.operator.tekton.dev
labels:
version: "devel"
operator.tekton.dev/release: "devel"
version: {{ .Chart.AppVersion | quote }}
operator.tekton.dev/release: {{ .Chart.AppVersion | quote }}
spec:
group: operator.tekton.dev
names:
Expand Down Expand Up @@ -5649,8 +5649,8 @@ metadata:
controller-gen.kubebuilder.io/version: v0.18.0
name: tektonresults.operator.tekton.dev
labels:
version: "devel"
operator.tekton.dev/release: "devel"
version: {{ .Chart.AppVersion | quote }}
operator.tekton.dev/release: {{ .Chart.AppVersion | quote }}
spec:
group: operator.tekton.dev
names:
Expand Down Expand Up @@ -6538,8 +6538,8 @@ metadata:
controller-gen.kubebuilder.io/version: v0.18.0
name: tektontriggers.operator.tekton.dev
labels:
version: "devel"
operator.tekton.dev/release: "devel"
version: {{ .Chart.AppVersion | quote }}
operator.tekton.dev/release: {{ .Chart.AppVersion | quote }}
spec:
group: operator.tekton.dev
names:
Expand Down Expand Up @@ -7241,8 +7241,8 @@ metadata:
controller-gen.kubebuilder.io/version: v0.18.0
name: tektonpruners.operator.tekton.dev
labels:
version: "devel"
operator.tekton.dev/release: "devel"
version: {{ .Chart.AppVersion | quote }}
operator.tekton.dev/release: {{ .Chart.AppVersion | quote }}
spec:
group: operator.tekton.dev
names:
Expand Down Expand Up @@ -8064,8 +8064,8 @@ metadata:
controller-gen.kubebuilder.io/version: v0.18.0
name: tektonschedulers.operator.tekton.dev
labels:
version: "devel"
operator.tekton.dev/release: "devel"
version: {{ .Chart.AppVersion | quote }}
operator.tekton.dev/release: {{ .Chart.AppVersion | quote }}
spec:
group: operator.tekton.dev
names:
Expand Down Expand Up @@ -8739,8 +8739,8 @@ metadata:
controller-gen.kubebuilder.io/version: v0.18.0
name: tektonmulticlusterproxyaaes.operator.tekton.dev
labels:
version: "devel"
operator.tekton.dev/release: "devel"
version: {{ .Chart.AppVersion | quote }}
operator.tekton.dev/release: {{ .Chart.AppVersion | quote }}
spec:
group: operator.tekton.dev
names:
Expand Down Expand Up @@ -9383,8 +9383,8 @@ metadata:
controller-gen.kubebuilder.io/version: v0.18.0
name: syncerservices.operator.tekton.dev
labels:
version: "devel"
operator.tekton.dev/release: "devel"
version: {{ .Chart.AppVersion | quote }}
operator.tekton.dev/release: {{ .Chart.AppVersion | quote }}
spec:
group: operator.tekton.dev
names:
Expand Down
52 changes: 26 additions & 26 deletions charts/tekton-operator/templates/openshift-crds.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ metadata:
controller-gen.kubebuilder.io/version: v0.18.0
name: manualapprovalgates.operator.tekton.dev
labels:
version: "devel"
operator.tekton.dev/release: "devel"
version: {{ .Chart.AppVersion | quote }}
operator.tekton.dev/release: {{ .Chart.AppVersion | quote }}
spec:
group: operator.tekton.dev
names:
Expand Down Expand Up @@ -652,8 +652,8 @@ metadata:
controller-gen.kubebuilder.io/version: v0.18.0
name: openshiftpipelinesascodes.operator.tekton.dev
labels:
version: "devel"
operator.tekton.dev/release: "devel"
version: {{ .Chart.AppVersion | quote }}
operator.tekton.dev/release: {{ .Chart.AppVersion | quote }}
spec:
group: operator.tekton.dev
names:
Expand Down Expand Up @@ -1375,8 +1375,8 @@ metadata:
controller-gen.kubebuilder.io/version: v0.18.0
name: tektonaddons.operator.tekton.dev
labels:
version: "devel"
operator.tekton.dev/release: "devel"
version: {{ .Chart.AppVersion | quote }}
operator.tekton.dev/release: {{ .Chart.AppVersion | quote }}
spec:
group: operator.tekton.dev
names:
Expand Down Expand Up @@ -1569,8 +1569,8 @@ metadata:
controller-gen.kubebuilder.io/version: v0.18.0
name: tektonchains.operator.tekton.dev
labels:
version: "devel"
operator.tekton.dev/release: "devel"
version: {{ .Chart.AppVersion | quote }}
operator.tekton.dev/release: {{ .Chart.AppVersion | quote }}
spec:
group: operator.tekton.dev
names:
Expand Down Expand Up @@ -2541,8 +2541,8 @@ metadata:
controller-gen.kubebuilder.io/version: v0.18.0
name: tektonconfigs.operator.tekton.dev
labels:
version: "devel"
operator.tekton.dev/release: "devel"
version: {{ .Chart.AppVersion | quote }}
operator.tekton.dev/release: {{ .Chart.AppVersion | quote }}
spec:
group: operator.tekton.dev
names:
Expand Down Expand Up @@ -4643,8 +4643,8 @@ metadata:
controller-gen.kubebuilder.io/version: v0.18.0
name: tektoninstallersets.operator.tekton.dev
labels:
version: "devel"
operator.tekton.dev/release: "devel"
version: {{ .Chart.AppVersion | quote }}
operator.tekton.dev/release: {{ .Chart.AppVersion | quote }}
spec:
group: operator.tekton.dev
names:
Expand Down Expand Up @@ -4757,8 +4757,8 @@ metadata:
controller-gen.kubebuilder.io/version: v0.18.0
name: tektonpipelines.operator.tekton.dev
labels:
version: "devel"
operator.tekton.dev/release: "devel"
version: {{ .Chart.AppVersion | quote }}
operator.tekton.dev/release: {{ .Chart.AppVersion | quote }}
spec:
group: operator.tekton.dev
names:
Expand Down Expand Up @@ -5628,8 +5628,8 @@ metadata:
controller-gen.kubebuilder.io/version: v0.18.0
name: tektonresults.operator.tekton.dev
labels:
version: "devel"
operator.tekton.dev/release: "devel"
version: {{ .Chart.AppVersion | quote }}
operator.tekton.dev/release: {{ .Chart.AppVersion | quote }}
spec:
group: operator.tekton.dev
names:
Expand Down Expand Up @@ -6517,8 +6517,8 @@ metadata:
controller-gen.kubebuilder.io/version: v0.18.0
name: tektontriggers.operator.tekton.dev
labels:
version: "devel"
operator.tekton.dev/release: "devel"
version: {{ .Chart.AppVersion | quote }}
operator.tekton.dev/release: {{ .Chart.AppVersion | quote }}
spec:
group: operator.tekton.dev
names:
Expand Down Expand Up @@ -7220,8 +7220,8 @@ metadata:
controller-gen.kubebuilder.io/version: v0.18.0
name: tektonpruners.operator.tekton.dev
labels:
version: "devel"
operator.tekton.dev/release: "devel"
version: {{ .Chart.AppVersion | quote }}
operator.tekton.dev/release: {{ .Chart.AppVersion | quote }}
spec:
group: operator.tekton.dev
names:
Expand Down Expand Up @@ -8043,8 +8043,8 @@ metadata:
controller-gen.kubebuilder.io/version: v0.18.0
name: tektonschedulers.operator.tekton.dev
labels:
version: "devel"
operator.tekton.dev/release: "devel"
version: {{ .Chart.AppVersion | quote }}
operator.tekton.dev/release: {{ .Chart.AppVersion | quote }}
spec:
group: operator.tekton.dev
names:
Expand Down Expand Up @@ -8718,8 +8718,8 @@ metadata:
controller-gen.kubebuilder.io/version: v0.18.0
name: tektonmulticlusterproxyaaes.operator.tekton.dev
labels:
version: "devel"
operator.tekton.dev/release: "devel"
version: {{ .Chart.AppVersion | quote }}
operator.tekton.dev/release: {{ .Chart.AppVersion | quote }}
spec:
group: operator.tekton.dev
names:
Expand Down Expand Up @@ -9362,8 +9362,8 @@ metadata:
controller-gen.kubebuilder.io/version: v0.18.0
name: syncerservices.operator.tekton.dev
labels:
version: "devel"
operator.tekton.dev/release: "devel"
version: {{ .Chart.AppVersion | quote }}
operator.tekton.dev/release: {{ .Chart.AppVersion | quote }}
spec:
group: operator.tekton.dev
names:
Expand Down
4 changes: 2 additions & 2 deletions hack/sync-helm-crds.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ inject_labels() {
# After the " name: ..." line under metadata, inject labels
if echo "$line" | grep -qE '^ name: .*\.operator\.tekton\.dev$'; then
echo ' labels:' >> "$tmpfile"
echo ' version: "devel"' >> "$tmpfile"
echo ' operator.tekton.dev/release: "devel"' >> "$tmpfile"
echo ' version: {{ .Chart.AppVersion | quote }}' >> "$tmpfile"
echo ' operator.tekton.dev/release: {{ .Chart.AppVersion | quote }}' >> "$tmpfile"
fi
done < "$input_file"
cat "$tmpfile"
Expand Down
Loading