fix(lighthouse): use resultspath output instead of manifest#90
Conversation
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughThe Lighthouse scan workflow now renders its summary from a runtime ChangesWorkflow validation update
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/lint.yml:
- Line 40: The checkout ref currently uses github.sha unconditionally, which
breaks when this workflow is triggered from a different repository context.
Update the checkout logic in the workflow so the ref is chosen based on the
repository context: keep using the current commit SHA only when running in the
workflow’s own repo, and fall back to a stable branch or tag when the workflow
is running against an external repository. Use the existing repository/checkout
settings near the ref value to make the conditional change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: f9685535-6de8-4479-80a0-2e5520e5423c
📒 Files selected for processing (2)
.github/workflows/lighthouse-scan.yml.github/workflows/lint.yml
Summary
property "manifest" is not definedtreosh/lighthouse-ci-action@v12outputsresultspath,links,assertionresults— notmanifestTest plan
Summary by CodeRabbit