Skip to content

fix(lighthouse): use resultspath output instead of manifest#90

Merged
tehw0lf merged 6 commits into
mainfrom
fix/lighthouse-manifest-output
Jun 24, 2026
Merged

fix(lighthouse): use resultspath output instead of manifest#90
tehw0lf merged 6 commits into
mainfrom
fix/lighthouse-manifest-output

Conversation

@tehw0lf

@tehw0lf tehw0lf commented Jun 24, 2026

Copy link
Copy Markdown
Owner

Summary

  • Fixes actionlint error: property "manifest" is not defined
  • treosh/lighthouse-ci-action@v12 outputs resultspath, links, assertionresults — not manifest
  • Reads scores from the results JSON file instead of a non-existent output property

Test plan

  • Merge this PR first
  • Verify tehwol.fi #286 lint check passes

Summary by CodeRabbit

  • Chores
    • Improved the Lighthouse scan workflow so the GitHub step summary consistently renders the “Lighthouse Audit Results” section from generated artifacts when available, while still linking to full reports.
    • Made the Lighthouse results table generation conditional on the presence of the runtime manifest.
    • Updated workflow linting to align validated workflow content with the triggering commit when applicable, and adjusted actionlint to ignore a newly surfaced known warning.

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

The Lighthouse scan workflow now renders its summary from a runtime manifest.json lookup, actionlint ignores the related output warning, and the lint workflow checks out the current run commit SHA.

Changes

Workflow validation update

Layer / File(s) Summary
Lighthouse summary rendering
.github/workflows/lighthouse-scan.yml
The Lighthouse scan step writes a new header, looks for a .lighthouseci/manifest.json file at runtime, and only renders table rows when that file exists.
Lint workflow checkout and ignore
.github/actionlint.yaml, .github/workflows/lint.yml
The actionlint configuration adds an ignore rule for the Lighthouse CI action output warning, and the lint workflow checks out tehw0lf/workflows at the triggering commit SHA.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • tehw0lf/workflows#89: Updates the Lighthouse scan workflow behavior that this PR further adjusts for summary rendering.

Poem

🐰 I hopped through logs with twitchy nose,
and found a manifest where the lighthouse glows.
The lint was calm, the ref was right,
and carrots sparkled in the night.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main Lighthouse workflow fix: switching from the nonexistent manifest output to resultspath.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/lighthouse-manifest-output

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/lint.yml:
- Line 40: The checkout ref currently uses github.sha unconditionally, which
breaks when this workflow is triggered from a different repository context.
Update the checkout logic in the workflow so the ref is chosen based on the
repository context: keep using the current commit SHA only when running in the
workflow’s own repo, and fall back to a stable branch or tag when the workflow
is running against an external repository. Use the existing repository/checkout
settings near the ref value to make the conditional change.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f9685535-6de8-4479-80a0-2e5520e5423c

📥 Commits

Reviewing files that changed from the base of the PR and between d4d47b3 and 0469cbf.

📒 Files selected for processing (2)
  • .github/workflows/lighthouse-scan.yml
  • .github/workflows/lint.yml

Comment thread .github/workflows/lint.yml Outdated
@tehw0lf tehw0lf merged commit 7cabfea into main Jun 24, 2026
2 of 3 checks passed
@tehw0lf tehw0lf deleted the fix/lighthouse-manifest-output branch June 24, 2026 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant