Wifi fallback fix#6
Open
privatereese wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves “WiFi fallback” / offline detection behavior in the tecff packages by hardening gateway-quality detection, fixing autoupdater execution flow, and making WiFi scanning + upgrade scheduling more robust.
Changes:
- Make SSID switching more robust when a default gateway exists but no batman gateway is selected.
- Fix autoupdater execution handling (propagate
os.executereturn) and harden WiFi scanlist handling against missing iwinfo backends / nil results. - Make the upgrade step resilient if
/usr/lib/micron.d/autoupdateris missing or unparsable; bump package versions/releases.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tecff-ssid-changer/Makefile | Bumps package release. |
| tecff-ssid-changer/files/lib/gluon/ssid-changer/ssid-changer.sh | Suppresses batctl stderr and adds empty-output fallback for gateway TQ. |
| tecff-autoupdater-wifi-fallback/Makefile | Bumps package version. |
| tecff-autoupdater-wifi-fallback/luasrc/usr/sbin/autoupdater-wifi-fallback | Returns autoupdater exit status (enables == 0 success checks). |
| tecff-autoupdater-wifi-fallback/luasrc/usr/lib/lua/autoupdater-wifi-fallback/util.lua | Avoids crashing/invalid null return; tolerates missing iwinfo type/scan results. |
| tecff-autoupdater-wifi-fallback/luasrc/lib/gluon/upgrade/510-autoupdater-wifi-fallback | Makes minute parsing resilient when the micron autoupdater file is missing/unexpected. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
92
to
95
| local function run_autoupdater() | ||
| autil.log('out', 'executing the autoupdater...') | ||
| os.execute('/usr/sbin/autoupdater -f -b ' .. branch_name) | ||
| return os.execute('/usr/sbin/autoupdater -f -b ' .. branch_name) | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.