Skip to content

chore: more fixes#183

Merged
SWvheerden merged 1 commit into
mainfrom
sw_more_updates
Jul 9, 2026
Merged

chore: more fixes#183
SWvheerden merged 1 commit into
mainfrom
sw_more_updates

Conversation

@SWvheerden

Copy link
Copy Markdown
Contributor

Description

Motivation and Context

How Has This Been Tested?

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several Tari RFC documents to align with the actual implementation, specifically detailing stealth address protocols, hardware wallet transaction flows (including view keys, script signatures, and deterministic script offsets), and the current status of covenants, alongside minor typo and grammar fixes. The review feedback highlights several opportunities to improve technical accuracy and formatting, such as correcting pluralized field tags in covenant examples, clarifying that the helper wallet derives public rather than private stealth script spending keys, fixing malformed LaTeX math blocks, and refining the description of public keys in stealth addresses.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/RFC-0250_Covenants.md
Comment thread src/RFC-0205_HardwareTransactions.md
Comment thread src/RFC-0205_HardwareTransactions.md
Comment thread src/RFC-0203_StealthAddresses.md
@SWvheerden SWvheerden merged commit c084366 into main Jul 9, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant