Fix v3 documentation code snippets to match live previews#40
Open
diederik-lascaris wants to merge 1 commit intotallstackui:3.xfrom
Open
Fix v3 documentation code snippets to match live previews#40diederik-lascaris wants to merge 1 commit intotallstackui:3.xfrom
diederik-lascaris wants to merge 1 commit intotallstackui:3.xfrom
Conversation
Eight component examples had drift between the live preview and the code snippet shown under the copy button, so users copying the snippet could not reproduce what they saw above it: - Ui/Card COLOR: add missing `light` attribute to "Light Variation" - Ui/Avatar PRESENCE_POSITIONS: replace invalid top/bottom-left/right values with the valid right-top/right-bottom/left-top/left-bottom accepted by the component - Ui/Progress CIRCLE_FOOTER_SLOT: use <x-progress.circle> instead of <x-progress> to match the previewed component - Ui/Tooltip ICONS: add missing icon="shield-check" to the Right tooltip - Form/Currency LABEL_HINT: fix typo "Salady" -> "Salary" - Form/Number MIN_MAX: restore label, hint and match min/max values shown in the preview - Form/Password BASIC: fix case "TallStackUi" -> "TallStackUI" - Alpine INPUT: fix credit card value from "200.000" to a valid 16-digit card number so the custom mask demonstrates correctly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Eight component examples in the v3 docs had drift between the rendered live preview and the code snippet shown under the copy button, so users copying the snippet could not reproduce what they saw above it. This PR aligns each snippet with its preview.
Changes
COLOR— add missinglightattribute to the "Light Variation" cardPRESENCE_POSITIONS— replace invalidtop-left/top-right/bottom-left/bottom-rightvalues with the validright-top/right-bottom/left-top/left-bottomaccepted by the componentCIRCLE_FOOTER_SLOT— use<x-progress.circle>instead of<x-progress>to match the previewed componentICONS— add missingicon="shield-check"to the Right tooltipLABEL_HINT— fix typo "Salady" → "Salary"MIN_MAX— restore label, hint and match the min/max values shown in the previewBASIC— fix casing "TallStackUi" → "TallStackUI"INPUT— fix credit card value from "200.000" to a valid 16-digit card number so the custom mask demonstrates correctlyTest plan
./vendor/bin/pest --filter="V3"passes