feat(clients): allow non-dev API endpoint roots - #811
Open
Will Miller (w-miller) wants to merge 1 commit into
Open
Will Miller (w-miller) wants to merge 1 commit into
Will Miller (w-miller) wants to merge 1 commit into
Conversation
Will Miller (w-miller)
force-pushed
the
will.miller/api-is-dev
branch
3 times, most recently
from
September 11, 2024 13:54
d2a160d to
32a1d98
Compare
Specifying an API endpoint root to a client used to imply that the endpoint in use was for dev, which would disable TLS and token bearer authorisation. This is not always a valid assumption, for example when manually specifying a locational endpoint for Google PubSub to target a specific region, as such endpoints are for production and should therefore use TLS and authorisation. Fix this by allowing manual configuration of the `api_is_dev` setting when using a non-dev root, whilst maintaining the old behaviour by default for backwards compatibility.
Will Miller (w-miller)
force-pushed
the
will.miller/api-is-dev
branch
from
September 11, 2024 14:01
32a1d98 to
6622d35
Compare
Will Miller (w-miller)
marked this pull request as ready for review
September 11, 2024 14:07
Will Miller (w-miller)
requested review from
a team,
Kevin James (TheKevJames) and
Shaun Sawyer (shaundialpad)
as code owners
September 11, 2024 14:07
Will Miller (w-miller)
requested review from
Kelly Ma (eddiedialpad)
and removed request for
a team
September 11, 2024 14:07
Kevin James (TheKevJames)
added a commit
that referenced
this pull request
Mar 25, 2026
Specifying an API endpoint root to a client used to imply that the endpoint in use was for dev, which would disable TLS and token bearer authorisation. This is not always a valid assumption, for example when manually specifying a locational endpoint for Google PubSub to target a specific region, as such endpoints are for production and should therefore use TLS and authorisation. Fix this by allowing manual configuration of the `api_is_dev` setting when using a non-dev root, whilst maintaining the old behaviour by default for backwards compatibility. Co-Authored-By: Will Miller <will.miller@pexip.com>
Member
|
Sorry this one languished, and thanks for the fix! I just cherry-picked this onto mainline and will include it in upcoming releases. |
This was referenced Jul 8, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Specifying an API endpoint root to a client used to imply that the endpoint in use was for dev, which would disable TLS and token bearer authorisation. This is not always a valid assumption, for example when manually specifying a locational endpoint for Google PubSub to target a specific region, as such endpoints are for production and should therefore use TLS and authorisation.
Fix this by allowing manual configuration of the
api_is_devsetting when using a non-dev root, whilst maintaining the old behaviour by default for backwards compatibility.