feat: enforce OIDC login restrictions#558
Open
toyorg wants to merge 3 commits into
Open
Conversation
Add handling for `allowed_domains` and `allowed_users` in the OIDC callback, redirecting with `error_restricted_access` if access is denied. Include a corresponding error message on the login page. Also fix a test that accessed `user` without a null check.
toyorg
changed the title
Implement OIDC allowed_groups check in addition to existing allowed_domains and allowed_users restrictions. Also prevent auto-redirect to OIDC when the login page has an error state, so users can see the error message before being redirected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add handling for
allowed_domains,allowed_usersandallowed_groupsin the OIDC callback, redirecting witherror_restricted_accessif access is denied.Include a corresponding error message on the login page.
Also fix a test that accessed
userwithout a null check.