Repository navigation
android: avoid duplicate profile loading on view model initialization - #898
Merged
Merged
Conversation
IpnViewModel explicitly loads user profiles during initialization and also subscribes to Notifier.state, which triggers the same load on every emission. Since Notifier.state is a StateFlow, new collectors immediately receive its current value, so profiles and currentProfile requests are issued twice whenever an IpnViewModel is created. This removes the redundant explicit load. The initial StateFlow emission still loads profiles, and then subsequent state transitions and self node changes continue to trigger refreshes. Updates tailscale/corp#50274 Signed-off-by: kari-ts <kari@tailscale.com>
hiimtmac
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IpnViewModel explicitly loads user profiles during initialization and also subscribes to Notifier.state, which triggers the same load on every emission. Since Notifier.state is a StateFlow, new collectors immediately receive its current value, so profiles and currentProfile requests are issued twice whenever an IpnViewModel is created.
This removes the redundant explicit load. The initial StateFlow emission still loads profiles, and then subsequent state transitions and self node changes continue to trigger refreshes.
pdates tailscale/corp#50274