Repository navigation
Fix cleanup of active upload attachments - #373
Open
drredx009-stack wants to merge 1 commit into
Open
drredx009-stack wants to merge 1 commit into
drredx009-stack wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Cleanup can delete attachment while its being uploaded because the pasta is yet to be added to the shared list.
Fix
Keep a track of active uploads in the shared state, RAII guard registers each upload when it starts and unregisters when exits. Cleanup skips directories in active uploads.
Testing
"cargo check" [PASS]
Note: I formatted, I am really sorry some changes are just due to formatting.