Fix async JNI strict concurrency#730
Open
nerzh wants to merge 1 commit intoswiftlang:mainfrom
Open
Conversation
Collaborator
|
Hi thanks for the PR, I’m on holiday so unable to review deeply here this week. im worried about unsafe wrappers like this, and would like to explore other options |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem found:
Swift Java generated JNI wrappers for
asyncSwift functions no longer compile with newer Swift strict concurrency checks. The generatedTaskclosures capture JNI values and temporary Swift conversion values that are notSendable, so Swift reports data-race risk errors during compilation.How it was fixed:
I added an unchecked
Sendablewrapper for values that must cross into the generated asyncTaskbody. The generator now tracks, structurally, which temporary values are created during JNI-to-Swift parameter conversion and wraps only those values before creating the task. Inside the task, the original values are restored from the wrapper and used as before.This avoids fragile string parsing of generated Swift code and keeps the fix limited to async JNI generation. Existing async JNI tests were updated to match the new generated output.