Repository navigation
fix: webauthn sign in wording from the #100 review - #104
Merged
Merged
Conversation
- describe the observable result (later sign in with the same options id -> OPTIONS_NOT_FOUND_ERROR) instead of 'consumed atomically' - expired options are INVALID_OPTIONS_ERROR, not OPTIONS_NOT_FOUND_ERROR - CREDENTIAL_NOT_FOUND_ERROR also covers a credential whose user is not in the tenant - requests without a cdi-version header resolve to the latest CDI and consume too Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SamDP1AS8ybBhCc1CWBWWk
porcellus
force-pushed
the
fix/5.5-review-wording
branch
from
October 28, 2026 19:01
081d03c to
f5f0aae
Compare
Collaborator
Author
|
Restructured: this branch now carries only its own version's changes (the earlier push had duplicated the 5.4.1 / 5.5 wording fixes as extra commits). Those arrive by merging the base branches forward — #105 → |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #100 (merged before the review landed)
Applies Tamás's review on #100:
webauthnGeneratedOptionsIdreturnsOPTIONS_NOT_FOUND_ERROR) instead of "consumed atomically".INVALID_OPTIONS_ERROR(reason: "Options expired"), notOPTIONS_NOT_FOUND_ERROR; they only become "not found" after the 24h cleanup cron. Per-status descriptions added forINVALID_OPTIONS_ERROR/INVALID_AUTHENTICATOR_ERROR/INVALID_CREDENTIALS_ERROR.CREDENTIAL_NOT_FOUND_ERRORalso covers a credential whose user is not in the requested tenant.cdi-versionheader resolve to the latest CDI and consume the options too.The same text is carried into the 5.6 / 5.7 / 5.8 PRs (their base branches were cut from the pre-review 5.5 tip).