Skip to content

optimizer: do not parallelize distinct ops #7589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattnibs merged 1 commit into from
Nov 3, 2026
Merged

optimizer: do not parallelize distinct ops #7589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/optimizer/parallelize.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ func (o *Optimizer) concurrentPath(seq dag.Seq, sortKeys order.SortKeys) (length
return 0, nil, false, nil
}
return k, sortExprsForSortKeys(sortKeys), true, nil
case *dag.ForkOp, *dag.HeadOp, *dag.ScatterOp, *dag.TailOp, *dag.UniqOp, *dag.FuseOp,
case *dag.DistinctOp, *dag.ForkOp, *dag.HeadOp, *dag.ScatterOp, *dag.TailOp, *dag.UniqOp, *dag.FuseOp,
Comment thread
mattnibs marked this conversation as resolved.
Resolved
*dag.HashJoinOp, *dag.InferOp, *dag.JoinOp, *dag.OutputOp:
return k, sortExprsForSortKeys(sortKeys), true, nil
default:
Expand Down
19 changes: 19 additions & 0 deletions compiler/ztests/par-distinct.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
script: |
super compile -C -P 2 -dynamic 'from test.bsup | distinct a | count()'
echo ===
super compile -C -P 2 -dynamic 'from test.bsup | distinct a | sort a'

outputs:
- name: stdout
data: |
file test.bsup format bsup unordered project [a]
| distinct a
| aggregate
count:=count()
| values count
| output main
===
file test.bsup format bsup unordered
| distinct a
| sort a asc nulls last
| output main
Loading