build: update Rust to 1.99, install taplo from its release binary - #831
Merged
Merged
Conversation
Fix the new clippy lints, mostly nested ifs that become let-chains, in the code and in the configuration codegen templates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Format and Check Codegen jobs fail on every branch:
moonrepo/setup-rustbuildstaplo-cliwithcargo installwithout--locked, which now resolvesuuid 1.27.0. That release needs rustc 1.89, and our toolchain was 1.88.taplo from its release binary. Both jobs download the static taplo 0.10.0 release binary instead of building it. It's the same version, so formatting doesn't change, the jobs no longer compile taplo, and a future dependency release can't break them this way again.
Rust 1.99.
rust-toolchain.tomlmoves from 1.88 to the current stable, 1.99, andflake.lockupdatesrust-overlayso the Nix shell knows it. The new clippy lints are fixed:ifs are collapsed into let-chains, the style the codebase already uses. The generatedpgls_configurationrules files change through the codegen templates inxtask/codegen, not by hand.pgls_queryFFI code, function-item casts in the backtrace helpers, and an unused lifetime inpgls_treesitter.pgls_diagnosticsthat rustc now reports as never constructed are only used by tests that are commented out. They are marked#[allow(dead_code)].