Implement panel fullscreen mode - #1046
Open
orlinmalkja wants to merge 6 commits into
Open
Conversation
…llscreen i.e when we open fullscreen the panel and then open sidebar
…as for initialCount,
orlinmalkja
force-pushed
the
implement-panel-fullscreenMode
branch
from
June 3, 2026 12:53
d6c0e45 to
461295b
Compare
Collaborator
|
This feature lacks a concept for small panel sizes, please ensure that the panel header does not break when a panel has it's minimal width. Maybe we need to introduce the "..." menu again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds following
Approach: We use requestFullScreen browser function to open a certain html element in full screen. The problem with this is that the Popover, Radix elements since they are append to body by default, will not be shown. Thus I create a ref - container ref in the PanelContext. Each component which displays such Popover, Radix then uses this container to portal them into the container ref, in order to be able to see them in full screen.
Closes #1047