Skip to content

Implement panel fullscreen mode - #1046

Open
orlinmalkja wants to merge 6 commits into
mainfrom
implement-panel-fullscreenMode
Open

Implement panel fullscreen mode#1046
orlinmalkja wants to merge 6 commits into
mainfrom
implement-panel-fullscreenMode

Conversation

@orlinmalkja

@orlinmalkja orlinmalkja commented May 24, 2026

Copy link
Copy Markdown
Contributor

This PR adds following

  • Clicking fullscreen button in panel should open it in Full Screen
  • It should be possible to exit fullscreen by clicking the button or typing ESC key
  • In fullscreen - opening annotations sidebar should accomodate place for that
  • Clicking at any label in Panel should open respective dropdown, i.e in CollectionTItle, Manifest, Item Label, PanelViews

Approach: We use requestFullScreen browser function to open a certain html element in full screen. The problem with this is that the Popover, Radix elements since they are append to body by default, will not be shown. Thus I create a ref - container ref in the PanelContext. Each component which displays such Popover, Radix then uses this container to portal them into the container ref, in order to be able to see them in full screen.

Closes #1047

@orlinmalkja
orlinmalkja requested a review from paulpestov May 24, 2026 17:17
@orlinmalkja orlinmalkja self-assigned this May 24, 2026
@orlinmalkja
orlinmalkja force-pushed the implement-panel-fullscreenMode branch from d6c0e45 to 461295b Compare June 3, 2026 12:53
@paulpestov

Copy link
Copy Markdown
Collaborator

This feature lacks a concept for small panel sizes, please ensure that the panel header does not break when a panel has it's minimal width. Maybe we need to introduce the "..." menu again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clicking at full screen in panel should open Panel in full screen

2 participants