Build bootnode and keygen images natively per platform - #223
Merged
Merged
Conversation
The single ubuntu-latest job built linux/amd64, arm/v7, arm64/v8 and 386 itself, with no QEMU, and the Dockerfile pins every stage to --platform=$BUILDPLATFORM; every published variant therefore contained the same amd64 binary. subsquid/bootnode:latest (1.0.5) has an x86-64 ELF under its linux/arm64 entry, which Docker on Apple Silicon then runs under Rosetta, where libp2p's QUIC handshake breaks. Build bootnode and keygen on ubuntu-latest and ubuntu-24.04-arm in parallel, push each platform image untagged by digest, and combine the digests into the usual <image>:<version> and <image>:latest tags with `docker buildx imagetools create`. The observer stays amd64-only, as before. The 32-bit variants are dropped: nothing could ever run them. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The single ubuntu-latest job built linux/amd64, arm/v7, arm64/v8 and 386 itself, with no QEMU, and the Dockerfile pins every stage to --platform=$BUILDPLATFORM; every published variant therefore contained the same amd64 binary. subsquid/bootnode:latest (1.0.5) has an x86-64 ELF under its linux/arm64 entry, which Docker on Apple Silicon then runs under Rosetta, where libp2p's QUIC handshake breaks.
Build bootnode and keygen on ubuntu-latest and ubuntu-24.04-arm in parallel, push each platform image untagged by digest, and combine the digests into the usual![]()
: and ![]()
:latest tags with
docker buildx imagetools create. The observer stays amd64-only, as before. The 32-bit variants are dropped: nothing could ever run them.