✨ Add home page section preferences - #1392
Merged
Merged
Conversation
aaronleopold
reviewed
Sep 6, 2026
aaronleopold
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for working on this, I reviewed the changes this morning and have some feedback
Codecov Report❌ Patch coverage is
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Contributor
Author
|
Thanks for the detailed review, @aaronleopold! I've pushed updates addressing your feedback and merged the latest nightly changes. Whenever you have a chance, I'd appreciate another look. Happy to make any further adjustments! |
aaronleopold
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for making those updates! I have one remaining point, but otherwise I think this looks good
설정 필드를 Option<Arrangement>로 복원하고 저장 JSON의 구조 오류를 DB 조회 단계에서 None으로 처리한다. 홈과 탐색 설정, 인증 사용자 경로의 수동 JSON 변환을 제거하고 각 기본값과 홈 섹션 정규화를 유지한다. SQLite 회귀 테스트로 설정 보존과 조회 후 저장 복구를 확인한다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Home page sections currently have a fixed order and cannot be hidden. This adds an editor under Preferences → Home page to show or hide the four existing sections, reorder them by dragging or keyboard, and save the layout per user. Reset restores the default order and visibility. When every section is hidden, the home page provides a link back to preferences.
This implements the home-section portion of #245.
updateHomeArrangementand apply the same normalization when reading saved home sections: keep the first supported occurrence of each section, preserve its order and visibility, and append missing sections as hidden.linksfields from the built-in home section configurations.The shared server API can support a future mobile implementation. This PR adds the web editor and updates its documentation.
LLM tooling assisted with this contribution.
Validation
modelsandgraphql, GraphQL schema consistency, and client generation passed.nightly: aligned the home test withreact-routerand added explicit hook return types to fix declaration generation.Ready?
nightlyand notmainStump Contributor License Agreement
By contributing to Stump, you agree that your contributions will be licensed under the following licenses (where applicable):