Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Release-oriented update for migraph v1.6.3, primarily aligning the package with newer {manynet} expectations (diffusion model structure) and cleaning up exports/docs/packaging metadata to address downstream/reverse-dependency friction.
Changes:
- Updated diffusion goodness-of-fit logic (
test_fit()) and its tests to use the newer diffusion representation (notablyt). - Removed
%>%reexport plumbing and refreshed generated reexport docs accordingly. - Bumped package/dependency metadata and refreshed CRAN/build ignore settings and Rd formatting.
Reviewed changes
Copilot reviewed 9 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/testthat/test-tutorials_autograph.R | Removes a stray trailing line from the test file. |
| tests/testthat/test-model_distrib.R | Wraps play_diffusion() with as_diffusion() for test_fit() input. |
| R/reexports_classes.R | Removes the roxygen reexport stub for %>% (file deleted). |
| R/model_distrib.R | Updates test_fit() to use t and adjusts simulation reshaping accordingly. |
| R/migraph-package.R | Updates global variable declarations used to suppress R CMD check notes. |
| NAMESPACE | Drops %>% export and removes a redundant importFrom(dplyr, \%>%`)` entry. |
| man/tests.Rd | Trims trailing whitespace in “Other models:” seealso text. |
| man/test_distributions.Rd | Trims trailing whitespace in “Other models:” seealso text. |
| man/regression.Rd | Trims trailing whitespace in “Other models:” seealso text. |
| man/reexports.Rd | Updates reexports documentation to no longer mention %>% and modernizes generics links. |
| man/migraph-package.Rd | Adds an “Authors” subsection under \author{}. |
| DESCRIPTION | Bumps version to 1.6.3; raises R/manynet minimum versions; adds Config/roxygen2/version. |
| cran-comments.md | Updates submission notes to mention reverse dependency fixes. |
| .Rbuildignore | Ignores .positai and .claude. |
| .gitignore | Ignores .positai. |
Files not reviewed (2)
- man/migraph-package.Rd: Generated file
- man/reexports.Rd: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Package
%>%reexport plumbing and refreshed generated reexport docs accordinglyTesting
test_fit()) and its tests to use the newer diffusion representation (notablyt)Checklist: