Skip to content

v1.6.3#315

Merged
jhollway merged 5 commits into
mainfrom
develop
Jun 19, 2026
Merged

v1.6.3#315
jhollway merged 5 commits into
mainfrom
develop

Conversation

@jhollway

@jhollway jhollway commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

Description

Package

  • Removed %>% reexport plumbing and refreshed generated reexport docs accordingly

Testing

  • Updated diffusion goodness-of-fit logic (test_fit()) and its tests to use the newer diffusion representation (notably t)

Checklist:

  • Documentation
    • DESCRIPTION file version is bumped by the appropriate increment (major, minor, patch)
    • Date in DESCRIPTION is correct
    • Longer functions are commented inline or broken down into helper functions to help debugging
  • PR form
    • Title indicates expected version number
    • PR description above and the NEWS.md file are aligned
    • Description above itemizes changes under subsection titles, e.g. "## Data""
    • Closed, fixed, or related issues are referenced and explained in the description above, e.g. "Fixed #0 by adding A"

Copilot AI review requested due to automatic review settings June 19, 2026 20:02

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Release-oriented update for migraph v1.6.3, primarily aligning the package with newer {manynet} expectations (diffusion model structure) and cleaning up exports/docs/packaging metadata to address downstream/reverse-dependency friction.

Changes:

  • Updated diffusion goodness-of-fit logic (test_fit()) and its tests to use the newer diffusion representation (notably t).
  • Removed %>% reexport plumbing and refreshed generated reexport docs accordingly.
  • Bumped package/dependency metadata and refreshed CRAN/build ignore settings and Rd formatting.

Reviewed changes

Copilot reviewed 9 out of 16 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tests/testthat/test-tutorials_autograph.R Removes a stray trailing line from the test file.
tests/testthat/test-model_distrib.R Wraps play_diffusion() with as_diffusion() for test_fit() input.
R/reexports_classes.R Removes the roxygen reexport stub for %>% (file deleted).
R/model_distrib.R Updates test_fit() to use t and adjusts simulation reshaping accordingly.
R/migraph-package.R Updates global variable declarations used to suppress R CMD check notes.
NAMESPACE Drops %>% export and removes a redundant importFrom(dplyr, \%>%`)` entry.
man/tests.Rd Trims trailing whitespace in “Other models:” seealso text.
man/test_distributions.Rd Trims trailing whitespace in “Other models:” seealso text.
man/regression.Rd Trims trailing whitespace in “Other models:” seealso text.
man/reexports.Rd Updates reexports documentation to no longer mention %>% and modernizes generics links.
man/migraph-package.Rd Adds an “Authors” subsection under \author{}.
DESCRIPTION Bumps version to 1.6.3; raises R/manynet minimum versions; adds Config/roxygen2/version.
cran-comments.md Updates submission notes to mention reverse dependency fixes.
.Rbuildignore Ignores .positai and .claude.
.gitignore Ignores .positai.
Files not reviewed (2)
  • man/migraph-package.Rd: Generated file
  • man/reexports.Rd: Generated file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread R/model_distrib.R Outdated
Comment thread R/migraph-package.R Outdated
Comment thread DESCRIPTION
@jhollway jhollway merged commit 44ef17a into main Jun 19, 2026
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants